-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dataset Label Checking #169
Conversation
I'm not sure how to efficiently and correctly test this change. Should I test every potential way a user could make the dataset label? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing ideas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The testing approach you came up with is very clean. These are great.
It is a little unusual that _
would be allowed as a dataset label, but let's leave that behavior in order to keep the regex simple.
We should still update config.yml
to document the label name requirements. Besides that, I'll do some local testing and it will be ready.
Is ready to review |
No description provided.