Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dataset Label Checking #169

Merged
merged 8 commits into from
Jul 25, 2024

Conversation

ntalluri
Copy link
Collaborator

@ntalluri ntalluri commented Jul 8, 2024

No description provided.

@ntalluri
Copy link
Collaborator Author

ntalluri commented Jul 8, 2024

I'm not sure how to efficiently and correctly test this change. Should I test every potential way a user could make the dataset label?

@ntalluri ntalluri changed the title Update dataset label Add Dataset Label Checking Jul 8, 2024
Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing ideas

spras/config.py Show resolved Hide resolved
test/test_config.py Outdated Show resolved Hide resolved
@ntalluri ntalluri self-assigned this Jul 17, 2024
Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing approach you came up with is very clean. These are great.

It is a little unusual that _ would be allowed as a dataset label, but let's leave that behavior in order to keep the regex simple.

We should still update config.yml to document the label name requirements. Besides that, I'll do some local testing and it will be ready.

@ntalluri
Copy link
Collaborator Author

Is ready to review

@agitter agitter merged commit b4f8d51 into Reed-CompBio:master Jul 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants