Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation Implementation #170

Merged
merged 20 commits into from
Aug 23, 2024
Merged

Conversation

ntalluri
Copy link
Collaborator

@ntalluri ntalluri commented Jul 9, 2024

No description provided.

Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few initial thoughts.

Snakefile Outdated Show resolved Hide resolved
config/config.yaml Outdated Show resolved Hide resolved
spras/evaluation.py Outdated Show resolved Hide resolved
@ntalluri
Copy link
Collaborator Author

The first pass works for running all datasets over all gold standard data. Next pass will allow for a user to set which datasets to run over gold standard

@ntalluri ntalluri self-assigned this Jul 17, 2024
@ntalluri
Copy link
Collaborator Author

ntalluri commented Jul 19, 2024

I need to make a third pass at the code to allow for evaluation code to truly be optional

Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving a few initial comments but skipped evaluation.py for now. I'm still looking for the best source of EGFR evaluation data we can use for a test case on pathways created with the egfr.yml config file.

Snakefile Outdated Show resolved Hide resolved
Snakefile Outdated Show resolved Hide resolved
spras/config.py Outdated Show resolved Hide resolved
spras/config.py Outdated Show resolved Hide resolved
spras/runner.py Outdated Show resolved Hide resolved
@ntalluri
Copy link
Collaborator Author

Ready for review

Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I was going to have an EGFR-based test case be part of this initial pull request. Now, I think we should work to merge it soon and add that test case in a follow up pull request to test the actual precision calcuation.

config/config.yaml Show resolved Hide resolved
spras/config.py Outdated Show resolved Hide resolved
spras/config.py Outdated Show resolved Hide resolved
spras/config.py Show resolved Hide resolved
spras/evaluation.py Outdated Show resolved Hide resolved
spras/evaluation.py Outdated Show resolved Hide resolved
spras/evaluation.py Outdated Show resolved Hide resolved
spras/runner.py Outdated Show resolved Hide resolved
@agitter agitter mentioned this pull request Aug 18, 2024
7 tasks
Co-authored-by: Anthony Gitter <[email protected]>
config/config.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a couple final changes. This is ready to merge once the tests pass.

@agitter agitter merged commit cf0b401 into Reed-CompBio:master Aug 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants