Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MEO Node ID Error #190

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Conversation

ntalluri
Copy link
Collaborator

#189 fixing this issue

@ntalluri
Copy link
Collaborator Author

The way I made generate-inputs test suite would require me to change the format of data1 and data0 to test MEO's update.

Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution looks good to me.

The way I made generate-inputs test suite would require me to change the format of data1 and data0 to test MEO's update.

Does this still need to be done?

spras/meo.py Show resolved Hide resolved
@ntalluri
Copy link
Collaborator Author

ntalluri commented Nov 4, 2024

The solution looks good to me.

The way I made generate-inputs test suite would require me to change the format of data1 and data0 to test MEO's update.

Does this still need to be done?

I just added an idea, but the only thing I wasn't able to change is the parse_outputs domino case

@ntalluri
Copy link
Collaborator Author

ntalluri commented Nov 7, 2024

localized the testing to be done only in generate inputs instead of it being coupled to the changes in inputs and the config.yaml file used as the examples.

@ntalluri ntalluri requested a review from agitter November 7, 2024 18:06
@agitter agitter merged commit 1a34151 into Reed-CompBio:master Nov 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants