fix: make dataset nodes ordering stable #363
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main change:
spras/spras/dataset.py
Lines 107 to 108 in a61bfce
Some algorithms depend on the ordering of their nodes, which is why this is marked as needed for benchmarking: we can guarantee immutable generated outputs this way. We never want the behavior of #362 falsely flagged as immutable.
This also adds tests to all inputs, closing #336.
This will be annoying to review. I have at least gone through and compared it with the regular input file to see that this looks right, but a thorough review of all of the test files will be unfortunately tedious.