Skip to content

Conversation

tristan-f-r
Copy link
Collaborator

@tristan-f-r tristan-f-r commented Jul 29, 2025

This is the main change:

spras/spras/dataset.py

Lines 107 to 108 in a61bfce

# We get uniqueness afterwards to make `load_files_from_dict` have a well-defined node ordering
nodes = list(pd.concat([self.interactome.Interactor1, self.interactome.Interactor2]).unique())

Some algorithms depend on the ordering of their nodes, which is why this is marked as needed for benchmarking: we can guarantee immutable generated outputs this way. We never want the behavior of #362 falsely flagged as immutable.


This also adds tests to all inputs, closing #336.

This will be annoying to review. I have at least gone through and compared it with the regular input file to see that this looks right, but a thorough review of all of the test files will be unfortunately tedious.

@tristan-f-r tristan-f-r marked this pull request as draft July 29, 2025 21:11
@tristan-f-r

This comment was marked as outdated.

@tristan-f-r tristan-f-r marked this pull request as ready for review July 29, 2025 21:36
@tristan-f-r tristan-f-r added needed for benchmarking Priority PRs needed for the benchmarking paper infrastructure misc. changes made to SPRAS itself labels Jul 29, 2025
@tristan-f-r tristan-f-r changed the title test: all inputs fix: make dataset nodes ordering stable Jul 31, 2025
@tristan-f-r tristan-f-r linked an issue Jul 31, 2025 that may be closed by this pull request
Copy link

Documentation build overview

📚 spras | 🛠️ build #29151356 (fd804a2) | 🔍 preview

Files changed

Comparing with latest (a9cff01...fd804a2)

Show files (4) | 4 modified | 0 added | 0 deleted
File Status
genindex.html 📝 modified
contributing/index.html 📝 modified
fordevs/modules.html 📝 modified
fordevs/spras.html 📝 modified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure misc. changes made to SPRAS itself needed for benchmarking Priority PRs needed for the benchmarking paper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate_inputs over all required_inputs
1 participant