Skip to content

Conversation

@NickleDave
Copy link
Collaborator

Redone as described in #74

@NickleDave
Copy link
Collaborator Author

Build from PR is here:
https://dev-review--75.org.readthedocs.build/en/75/

@NickleDave NickleDave requested review from bielsnohr and tlestang June 5, 2022 22:04
Copy link
Collaborator

@bielsnohr bielsnohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NickleDave ! Thanks for the great work on this, and sorry it took so long to get around to looking at it. I think overall, the site looks really good in this format. A few additional things to consider:

  • I think we probably should change the name of the readthedocs site, but perhaps lets address that in a separate issue and PR.
  • There are a lot of warnings spit out by Sphinx, but the site does build. Again, probably something to address is a separate issue and PR. Happy to raise one.
  • We need a better navigation bar on the side that allows for navigation throughout the site. Does sphinx-book-theme have this capability?

@NickleDave
Copy link
Collaborator Author

@bielsnohr I think this addresses all your requested changes.

Any in-line request that you mentioned in comments I raised separate issues for.
If you all agree, I'd prefer to get this merged in and re-work from that base, instead of iterating forever on this branch.

Copy link
Collaborator

@bielsnohr bielsnohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments. Happy to have this merged and then address other bigger items in the separate issues that @NickleDave has raised.

@NickleDave NickleDave force-pushed the switch-sphinx-book-theme branch from 575fb3d to 40badfb Compare August 21, 2022 18:46
@NickleDave NickleDave merged commit 2a89671 into ResearchCodeReviewCommunity:main Aug 24, 2022
@NickleDave NickleDave deleted the switch-sphinx-book-theme branch October 2, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants