Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workaround for Webcharts All subsetter logic. #236

Closed
samussiah opened this issue Feb 22, 2019 · 4 comments
Closed

Add a workaround for Webcharts All subsetter logic. #236

samussiah opened this issue Feb 22, 2019 · 4 comments

Comments

@samussiah
Copy link
Contributor

samussiah commented Feb 22, 2019

If the filter variable has a value of All Webcharts counts All twice.

Test notes

  • Verify that if All appears in a variable underlying a filter, it also appears as an option in the filter dropdown separate from the default All option:
    • Choose a renderer with a default All filter: ae-timelines, crf-heat-map, participant-visit-listing, or clinical-timelines.
    • Download the data file.
    • Add a value of All to one of the All filter columns.
    • Upload the modified data file.
    • Render the chart and verify the filter contains two All options, one that selects all data and one that selects only the modified record.
@jwildfire
Copy link
Contributor

@samussiah Is there an easy fix for this? If so, shall we address along with #238 in v1.11.3?

pburnsdata added a commit that referenced this issue Feb 28, 2019
@samussiah
Copy link
Contributor Author

Webcharts has logic here that doesn't allow a value of All in the data to filter correctly. It's an edge case and one that can be avoided by replacing All with a different value (Overall, All Records, etc.). More difficult to fix than I figured.

@samussiah
Copy link
Contributor Author

issue logged to address All subsetter logic in ae-timelines

@danedexF5
Copy link

It works mostly. There is an edge case where updating a field to All can error CRF, CT and PVL. Spencer is aware and there are issues opened for those 3 renderers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants