Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oxford API version 2 support #13

Closed
wants to merge 2 commits into from
Closed

Oxford API version 2 support #13

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 25, 2020

Tested with go1.14

@ghost
Copy link
Author

ghost commented Mar 25, 2020

Just tested these changes with go1.11 as well as 1.14 and they run locally. Below are some sources that seem related to the CI checks.


golang/lint
Resolving Module Path Problems
Non-canonical paths
x/build go.mod dependency update

@ghost ghost mentioned this pull request Mar 25, 2020
@ghost
Copy link
Author

ghost commented Mar 27, 2020

I am able to replicate the errored check with make install-deps-dev.

A potential solution is to replace github.com/golang/lint/golint with golang.org/x/lint.

diff --git a/Makefile b/Makefile
index df1bc0f..c445391 100644
--- a/Makefile
+++ b/Makefile
@@ -70,7 +70,7 @@ install-deps:
        go get -d ./...

 install-deps-dev: install-deps
-       go get github.com/golang/lint/golint
+       go get golang.org/x/lint
        go get golang.org/x/tools/cmd/goimports
        go get github.com/mitchellh/gox

@@ -78,7 +78,7 @@ update-deps:
        go get -d -u ./...

 update-deps-dev: update-deps
-       go get -u github.com/golang/lint/golint
+       go get -u golang.org/x/lint
        go get -u golang.org/x/tools/cmd/goimports
        go get -u github.com/mitchellh/gox

This change to the Makefile yields success in go1.14, however make install-deps-dev in go1.11 fails.

Below is the result:

make install-deps-dev
go1.11 get -d ./...
go1.11 get golang.org/x/lint
go: finding golang.org/x/lint latest
go1.11 get golang.org/x/tools/cmd/goimports
go: finding golang.org/x/tools/cmd/goimports latest
go: finding golang.org/x/tools/cmd latest
go: finding golang.org/x/tools latest
go: downloading golang.org/x/tools v0.0.0-20200327195553-82bb89366a1e
go build golang.org/x/mod/semver: module requires Go 1.12
Makefile:76: recipe for target 'install-deps-dev' failed
make: *** [install-deps-dev] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants