fixing a few warnings

RoboJackets · Apr 28, 2024 · 7bee27e · 7bee27e
1 parent 3a78242
commit 7bee27e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/soccer/src/soccer/game_state.hpp b/soccer/src/soccer/game_state.hpp
@@ -151,7 +151,7 @@ struct PlayState {
                ball_placement_point() == other.ball_placement_point();
     }
 
-    bool same_as(const PlayState& other) const {
+    [[nodiscard]] bool same_as(const PlayState& other) const {
         return state_ == other.state_ && restart_ == other.restart_ &&
                our_restart_ == other.our_restart_;
     }

diff --git a/soccer/src/soccer/planning/planner_for_robot.cpp b/soccer/src/soccer/planning/planner_for_robot.cpp
@@ -132,7 +132,7 @@ PlanRequest PlannerForRobot::make_request(const RobotIntent& intent) {
             max_dribbler_speed = 0;
             break;
         case PlayState::State::Setup:
-            // TODO: this is a hacky solution for us to stop kicking the ball by
+            // TODO(jacksherling): this is a hacky solution for us to stop kicking the ball by
             // accident in kickoff, not an actual league rule
             min_dist_from_ball = 0.2;
             max_robot_speed = 10.0;

diff --git a/soccer/src/soccer/strategy/agent/position/pivot_test.hpp b/soccer/src/soccer/strategy/agent/position/pivot_test.hpp
@@ -27,6 +27,9 @@ class Pivot : public Position {
     Pivot(const Pivot& other) = default;
     Pivot(Pivot&& other) = default;
 
+    Pivot& operator=(const Pivot& other) = delete;
+    Pivot& operator=(Pivot&& other) = delete;
+
     std::string get_current_state() override;
 
 private: