Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement i18n #36

Merged
merged 14 commits into from
Mar 25, 2024
Merged

Implement i18n #36

merged 14 commits into from
Mar 25, 2024

Conversation

Tenebrosful
Copy link
Contributor

#35

@Tenebrosful Tenebrosful marked this pull request as ready for review March 23, 2024 09:09
@Tenebrosful
Copy link
Contributor Author

Know bug

Commands descriptions and "Connected to Discord" strings aren't translated because SMAPI loads game lang after Entry (see Pathoschild/SMAPI#938)

@RuiNtD
Copy link
Owner

RuiNtD commented Mar 23, 2024

I'm probably going to be making some changes to the code if I introduce i18n, like changing "1 tag unavailable" to "1 tag(s) unavailable," since I know plurals complicate i18n in some languages. Also, I'm going to change "DiscordRP is not supported on Android. Aborting mod initialization." to "Discord Rich Presence is untested on this platform and may not work." This would show up in console and on the title screen and I would also add a config option to "Disable Untested Platform Warning".

Decided to remove this warning altogether.

@Tenebrosful
Copy link
Contributor Author

I'm probably going to be making some changes to the code if I introduce i18n, like changing "1 tag unavailable" to "1 tag(s) unavailable," since I know plurals complicate i18n in some languages. Also, I'm going to change "DiscordRP is not supported on Android. Aborting mod initialization." to "Discord Rich Presence is untested on this platform and may not work." This would show up in console and on the title screen and I would also add a config option to "Disable Untested Platform Warning".

Decided to remove this warning altogether.

Yeah, i tried to transform current code to i18n even with plurals, most of job is done so changes shouldn't be hard

@RuiNtD
Copy link
Owner

RuiNtD commented Mar 25, 2024

@Tenebrosful Can you do one quick pass to make sure everything French is translated correctly? I did change around some of the keys. Once you can confirm it's good, I'll go ahead and merge. Thanks for the help!

Also, can you confirm if Pathoschild/SMAPI#938 is still an issue after switching to the strongly-typed API?

@RuiNtD RuiNtD linked an issue Mar 25, 2024 that may be closed by this pull request
@Tenebrosful
Copy link
Contributor Author

Legit for me, but yeah still an issue but i don't think it can really be resolve by ourself

@RuiNtD RuiNtD merged commit 7bbb032 into RuiNtD:main Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] Support i18n
2 participants