-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement i18n #36
Implement i18n #36
Conversation
Know bugCommands descriptions and "Connected to Discord" strings aren't translated because SMAPI loads game lang after Entry (see Pathoschild/SMAPI#938) |
I'm probably going to be making some changes to the code if I introduce i18n, like changing "1 tag unavailable" to "1 tag(s) unavailable," since I know plurals complicate i18n in some languages. Decided to remove this warning altogether. |
Yeah, i tried to transform current code to i18n even with plurals, most of job is done so changes shouldn't be hard |
Includes adding ModTranslationClassBuilder
@Tenebrosful Can you do one quick pass to make sure everything French is translated correctly? I did change around some of the keys. Once you can confirm it's good, I'll go ahead and merge. Thanks for the help! Also, can you confirm if Pathoschild/SMAPI#938 is still an issue after switching to the strongly-typed API? |
Legit for me, but yeah still an issue but i don't think it can really be resolve by ourself |
#35