CI: upgrade GCC baseline from 4.8 -> 5.4 (5.5) #3262
Conversation
thesamesam
force-pushed
the
gcc-baseline
branch
2 times, most recently
from
834cfd7 to
c9f480f
Compare
|
Great, thanks! I was meaning to file an Issue for this -- now we've got a Pull Request already! :-D |
thesamesam
force-pushed
the
gcc-baseline
branch
from
c9f480f to
df79b77
Compare
thesamesam
changed the title
This was pointed out by tschwinge in a review [0]. Add a note to avoid that error happening in future. [0] Rust-GCC#3262 (comment) ChangeLog: * .github/workflows/ccpp.yml: Add note to keep in sync with .github/bors.toml.
|
I've removed all bors mention/files in #3263 |
thesamesam
force-pushed
the
gcc-baseline
branch
from
a146b89 to
bf08887
Compare
GCC's baseline was changed from C++11 -> C++14 and GCC 4.8 -> GCC 5.4 in r15-4719-ga9ec1bc06bd3cc, so adjust the baseline CI job accordingly. One quirk here is that the Ubuntu image we're using in CI has 5.5.0 rather than 5.4.0. But I think we can eat that difference. ChangeLog: * .github/workflows/ccpp.yml: Use GCC 5.5 instead of GCC 4.8.
thesamesam
force-pushed
the
gcc-baseline
branch
from
bf08887 to
699b987
Compare
|
It's not auto-merging, seemingly because |
|
@powerboat9: Yeah, probably. Where does it get that from, do you (or anyone else, of course) happen to know? I could easily push this manually, but not sure I should? Maybe wait for the pros to be back on Monday. ;-) |
Looks like a known issue when renaming names in workflows (see https://github.com/orgs/community/discussions/42874 for example). |
|
We may need the super powers of @CohenArthur for really merging this... |
|
Given we all agree, I went ahead and used my superpowerz -- let's have Arthur use his time for more interesting things. 👍 |
|
Here this doesnt seem to be working for me on new PR's see: https://github.com/Rust-GCC/gccrs/actions/runs/12019251579/job/33527105478?pr=3267 |
|
I think I remember seeing the gcc-4.8 failing in a similar way earlier. It looks like, as part of an automatic upgrade from node16 to node20 (?), the version of glibc used by ubuntu 18.04 is too old for node to use. |
GCC's baseline was changed from C++11 -> C++14 and GCC 4.8 -> GCC 5.4
in r15-4719-ga9ec1bc06bd3cc, so adjust the baseline CI job accordingly.
One quirk here is that the Ubuntu image we're using in CI has 5.5.0
rather than 5.4.0. But I think we can eat that difference.
ChangeLog:
* .github/workflows/ccpp.yml: Use GCC 5.5 instead of GCC 4.8.
* .github/bors.toml: Update CI job name.