-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ABAP language version optional and set standard as default #149
Conversation
heh, ALV is not "ABAP List Viewer" in this case 😀 |
Sorry my mistake. ALV = Abap Language Version. |
What can be mentioned here is that the Simple transformations of all objects are not yet updated (we have an open question regarding "d-cond"). I changed the example instances manually. We will update the STs in the next days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks also good to me :)
Sorry, I found one more thing after all: In the .json files of the interfaces describing the type, there is still written: "abapLanguageVersion":"standard" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @huber-nicolas.
In general, it looks good to me, but I think @wurzka's last comment should be considered:
Sorry, I found one more thing after all: In the .json files of the interfaces describing the type, there is still written: "abapLanguageVersion":"standard"
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
resolves #44