Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ABAP language version optional and set standard as default #149

Merged
merged 4 commits into from
Aug 4, 2021

Conversation

huber-nicolas
Copy link
Contributor

resolves #44

@larshp
Copy link
Collaborator

larshp commented Aug 4, 2021

heh, ALV is not "ABAP List Viewer" in this case 😀

@huber-nicolas
Copy link
Contributor Author

heh, ALV is not "ABAP List Viewer" in this case 😀

Sorry my mistake. ALV = Abap Language Version.
Next time I try to avoid the abbreviation ALV :-)

@huber-nicolas
Copy link
Contributor Author

What can be mentioned here is that the Simple transformations of all objects are not yet updated (we have an open question regarding "d-cond"). I changed the example instances manually. We will update the STs in the next days

Copy link
Collaborator

@larshp larshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@schneidermic0 schneidermic0 changed the title Make ALV optional and set standard as default Make ABAP language version optional and set standard as default Aug 4, 2021
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks also good to me :)

@wurzka
Copy link
Contributor

wurzka commented Aug 4, 2021

Sorry, I found one more thing after all: In the .json files of the interfaces describing the type, there is still written: "abapLanguageVersion":"standard"

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @huber-nicolas.

In general, it looks good to me, but I think @wurzka's last comment should be considered:

Sorry, I found one more thing after all: In the .json files of the interfaces describing the type, there is still written: "abapLanguageVersion":"standard"

@huber-nicolas
Copy link
Contributor Author

Thanks, @huber-nicolas.

In general, it looks good to me, but I think @wurzka's last comment should be considered:

Sorry, I found one more thing after all: In the .json files of the interfaces describing the type, there is still written: "abapLanguageVersion":"standard"

Done

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@huber-nicolas huber-nicolas merged commit ecbc90d into main Aug 4, 2021
@huber-nicolas huber-nicolas deleted the Make-ALV-optional-and-set-default-to-ALV branch August 4, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

abapLanguageVersion
4 participants