-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking changes with PCU #433
Open
flagdanger
wants to merge
147
commits into
SCOREC:develop
Choose a base branch
from
jacobmerson:pcu-object-breaking
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
147 commits
Select commit
Hold shift + click to select a range
feafdec
Add state to PCU mpi interface.
jacobmerson 7c390ee
Compile on gcc+fix bug
jacobmerson a4bbbfb
remove virtual function table for pcu_mpi
jacobmerson baf9370
Put PCU state data into a structure
jacobmerson 4c243cb
Use consistent initialization functions for MPI.
jacobmerson d891d2b
Add PCU2 interface that takes the PCU state struct
jacobmerson de2f57d
add PCU2.h to install files
jacobmerson 6a46101
fix compiler warnings
jacobmerson ed28c05
constify mpi functions
jacobmerson 2eada4e
first pass of PCU with making use of a high level object
jacobmerson eed5a0c
remove unused functions
jacobmerson f0b3a28
Fix gcc compilation
jacobmerson 0e7362f
fix bug
jacobmerson 0e0c80e
remove unnecessary whitespace
jacobmerson 07ab364
bump version
jacobmerson 80c829d
Add state to PCU mpi interface.
jacobmerson 2f6238c
Compile on gcc+fix bug
jacobmerson a5be7ae
remove virtual function table for pcu_mpi
jacobmerson 064ea13
Put PCU state data into a structure
jacobmerson e727d54
Use consistent initialization functions for MPI.
jacobmerson 47bf6d5
Add PCU2 interface that takes the PCU state struct
jacobmerson ef021f6
add PCU2.h to install files
jacobmerson 270d44e
fix compiler warnings
jacobmerson 62bfb69
constify mpi functions
jacobmerson 173c7ec
first pass of PCU with making use of a high level object
jacobmerson 23c7cef
remove unused functions
jacobmerson 438a73e
Fix gcc compilation
jacobmerson 4fa6e37
fix bug
jacobmerson 716133e
remove unnecessary whitespace
jacobmerson 4d281e0
bump version
jacobmerson 625b02b
Merge pull request #1 from flagdanger/pcu-object
jacobmerson 412addc
added pcu_ as a variable of Mesh
flagdanger 63bf279
Added getPCU(), and beginning to change pcu functions
flagdanger b364118
Can access global_pcu and some editing of function calls in /apf
flagdanger 1010eb1
Changed functions in more files up to folder ma
flagdanger 041b6f0
More PCU changes
flagdanger 435172e
More fixing
flagdanger 3f40db9
ph and pumi changes
flagdanger b1e41ff
more cleaning
flagdanger a2cb48f
test folder fixes
flagdanger da4383d
More test folder fixes
flagdanger 3c7b447
fixed last of test folder and made PCU2 .h and .cc
flagdanger 2ec87e3
Re-checked apf and pcu2 fix
flagdanger 3101beb
re-checking up to ma
flagdanger ee1d7e4
ma folder redo
flagdanger f13132e
more fixes
flagdanger 33a6621
Making new versions of functions to handle PCUHandle
flagdanger 8c5633a
phCook changes, changed phInput openfile_read to take PCUHandle, and …
flagdanger eaeaa3d
Reverting phasta changes
flagdanger 244a6d5
mds folder changed to use PCU2
flagdanger 5206e77
Last mds fixes (apfMDS.cc still has some issues)
flagdanger 8e2cdb0
Getting rid of include PCU.h in spots I missed
flagdanger 221a982
All parma changes I can do (lots of files need some workaround)
flagdanger 344e3c4
small pcu change
flagdanger 5ee39e5
pcu_getglobal changes
flagdanger cb971df
apfCap fix
flagdanger 2bb8171
crv fixes
flagdanger 23bf889
dsp pcu fix
flagdanger 60e0b6f
gmi cap and sim pcu fixes
flagdanger 63af137
ma pcu fixes
flagdanger 98e9d71
changing apfMDS.cc back to original, still needs work
flagdanger 6f49fb2
pumi pcu fixes
flagdanger 14d2e5e
spr pcu fix
flagdanger 5f17c05
stk pcu fixes
flagdanger bc1ce6a
changing repartition.cc back to original, still needs work
flagdanger 59d5a7f
zoltan pcu fixes
flagdanger 98341a3
pumi interface fixes, replacing old PCU uses
flagdanger a0c53fc
files in test folder changed to use new pumi - pcu interface
flagdanger 32ab95b
made default PCU arguments for Mesh functions and fixed old pcu issue…
flagdanger 530a82e
repartition test file rebuilt to use new pcu
flagdanger fda3f51
apf folder using new pcu except apfNumbering.cc
flagdanger bdce405
ma folder changed to use new pcu, changed some uses of print() in crv…
flagdanger 9075f4b
ma folder using new pcu, all tests passing
flagdanger efc2d77
changed phastaio_initStats to not check if PCU is intitialized. Also …
flagdanger d424963
Phasta folder changed to use new PCU, passes tests.
flagdanger 9005de8
small touchups in test files, apfMDS.cc, and apf_sim
flagdanger 6bb2806
Parma folder fixes, only thing not changed is parma_group.cc, all tes…
flagdanger 6cbd11d
added switchPCU to apfMesh to use in parma_group.cc
flagdanger 000418e
parma_group.cc fixed to use switchPCU, may need to change later
flagdanger bd265d8
parallelReduce function fix
flagdanger 7f83066
crv corrected makeEmptyMdsMesh use
flagdanger 8469c37
ma corrected makeEmptyMdsMesh use
flagdanger 2b90da5
fixed BoxBuilder class and loadMdsFromANSYS to take an optional PCUObj
flagdanger 961f09a
got rid of undef PCU_FORMAT_ATTRIBUTE, fixed compilation errors that …
flagdanger daed911
phasta - fixed createMdsMesh use
flagdanger 946ba7c
got rid of an #include PCU.h
flagdanger 8c28b15
#include PCU.h deletion
flagdanger 7a99da1
spr folder fixes
flagdanger 99ad2db
1d test file
flagdanger 77cb68f
align test file
flagdanger 1dc3a94
aniso_ma_test file
flagdanger becd83a
ansys test file
flagdanger e591d9a
assert_timing test file
flagdanger dc48ea7
balance test file
flagdanger 4624408
bezierElevation test file
flagdanger 0a7ccec
box test file
flagdanger 54cc6be
collapse test file
flagdanger f6e5d7c
poisson test file
flagdanger 5f0ef7e
mdsCGNS PCUHandle fix
flagdanger 6452f43
maximal independent set fixes
flagdanger 8cb06bb
Parma_GroupCode run() function default changed to take a PCUObj
flagdanger f36021a
Test files fixed
flagdanger 0db8e21
loadMdsPart take optional PCU
flagdanger 6f4c6df
loadMdsFromGmsh to take PCU
flagdanger 9900b46
fixed runInGroups() to work with new PCU
flagdanger b0a6ff2
reverted the run function in GroupCode structs to not take a PCU
flagdanger 52c9ab8
test files fixed to use PCUObj; all pass
flagdanger 1eebc1e
Mesh interface fixes
flagdanger 94dcc92
Test files changed to use new PCU
flagdanger 7dbae41
Added comments for uses of switchPCU
flagdanger 2b03519
added back reeResidualFunctionals.cc
flagdanger 00bf25e
Delete config.sh
flagdanger 2f23fb1
Merge pull request #2 from flagdanger/pcu-object
jacobmerson 03eb93d
Merge branch 'develop' into pcu-object
jacobmerson ea3b36e
Warning fixes
flagdanger b2ae31a
Merge branch 'pcu-object' of https://github.com/flagdanger/core into …
flagdanger d95cdcd
Merge pull request #3 from flagdanger/pcu-object
jacobmerson 769c432
compiler errors with phLinks.cc fixed
flagdanger f96b764
.github fix
flagdanger 1e3d684
describe.cc getPeak() and getChunks() removed
flagdanger e33b48d
removed last uses of old pcu, removed pcu.cc and .h, got rid of defau…
flagdanger 0dd10d1
small fixes
flagdanger 6e9a875
PCU2 using PCU naming, changed PCUHandle to PCU_t
flagdanger deba052
pumi_sys functions using pumi::instance to access PCU, added setPCU a…
flagdanger 687e160
added pumi_load_pcu to replace the use of setPCU, removed PCUObj as a…
flagdanger 7d57abc
apfSim typo fix
flagdanger e90602f
pumi_rank() replacements
flagdanger 55f887c
simmetrix create mesh typo fixed
flagdanger bfde63e
Merge remote-tracking branch 'SCOREC/develop' into pcu-object-breaking
flagdanger a904f02
phLinks ptr issue fix
flagdanger 77812e5
phasta convert fixes
flagdanger a907b7e
test files small bugs
flagdanger 8128e2a
Revert "test files small bugs"
flagdanger 94549c7
removed config file
flagdanger 73c5033
PCU.h small fix
flagdanger 90f9ff3
Delete config.sh
flagdanger 236bffb
long dereference chains fixed
flagdanger 7025e62
PCUObj renamed to PCU, PCU remaned to PCU_C
flagdanger 90785ed
Specified argument data type for templated functions PCU:: Add, Max, …
flagdanger 6faa765
Capstone updated to use PCU Object
flagdanger b5a2190
small fixes
flagdanger 85be809
Typo cleaning
flagdanger d5b7413
Test files changed to not use unique_ptr
flagdanger d666a1e
Removed uses of unique_ptr in other folders besides test
flagdanger 807746c
Removed semi colon after Macro
flagdanger 7e4cd5a
CGNS fixes
flagdanger 6e47c85
cgns fixes
flagdanger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwsmith marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwsmith marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwsmith marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the other examples the unique_ptr was removed, I assume that can be done here too?