Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possiblity to create your own "PluginBase" #175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Possiblity to create your own "PluginBase" #175

wants to merge 1 commit into from

Conversation

Spcemarine
Copy link

Changed PluginBase to IPlugin to make it possible to create your own
PluginBase that implements IPlugin.

Changed PluginBase to IPlugin to make it possible to create your own
PluginBase that implements IPlugin.
@generalwrex
Copy link
Contributor

What exactly would this do? Can you go into more detail please :)

@Spcemarine
Copy link
Author

Well, to detect if a class is a plugin or not the extender goes through the classes and checks if the baseclass implements IPlugin. This allows us to create our own baseclass for plugins. For example my plugins have to open database connections and since I dont want to implement each time I wrote my own baseclass like PluginBase that implements IPlugin and got an exception because it could not be cast to PluginBase. It would just be right if it is IPlugin instead of PluginBase because that is the sense of the interface, isn't it?

@ghost
Copy link

ghost commented Oct 10, 2014

As a plugin author, I agree with this change.

The PluginBase class is limiting and not necessary when we can implement the IPlugin interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants