Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent 'directory not empty' error in snowfakery on Linux #3864

Merged
merged 6 commits into from
Jan 17, 2025
Merged

fix: Prevent 'directory not empty' error in snowfakery on Linux #3864

merged 6 commits into from
Jan 17, 2025

Conversation

schenkkp
Copy link
Contributor

Implemented potential fix to address Linux issue on #3859. Please advise if any changes are requested.

@schenkkp schenkkp requested a review from a team as a code owner December 22, 2024 18:22
jstvz
jstvz previously requested changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@jstvz jstvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report and contribution, @schenkkp. This looks good, just one tweak to remove an extraneous import.

cumulusci/tasks/bulkdata/snowfakery.py Outdated Show resolved Hide resolved
@schenkkp schenkkp requested a review from jstvz January 16, 2025 00:30
@jstvz jstvz changed the title Update snowfakery.py to fix #3859 fix: Prevent 'directory not empty' error in snowfakery on Linux Jan 16, 2025
@jstvz jstvz requested a review from vsbharath January 17, 2025 21:03
@jstvz jstvz dismissed their stale review January 17, 2025 21:03

Committed to PR

vsbharath
vsbharath approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@vsbharath vsbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jstvz jstvz enabled auto-merge (squash) January 17, 2025 22:20
@jstvz jstvz merged commit 1d90c46 into SFDO-Tooling:main Jan 17, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstvz jstvz jstvz left review comments

@vsbharath vsbharath vsbharath approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schenkkp @jstvz @vsbharath