Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent 'directory not empty' error in snowfakery on Linux #3864

Merged
merged 6 commits into from
Jan 17, 2025
+4 −2
Merged

fix: Prevent 'directory not empty' error in snowfakery on Linux #3864

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
38d6611
Update snowfakery.py to fix #3859
schenkkp Dec 22, 2024
0cd883e
Merge branch 'main' into bug/linux-rename-working-dir
jstvz Jan 9, 2025
3ecbdcc
Merge branch 'main' into bug/linux-rename-working-dir
jstvz Jan 10, 2025
8e8a8db
Updated code to use Path library instead of os
schenkkp Jan 16, 2025
9e58960
Update cumulusci/tasks/bulkdata/snowfakery.py
jstvz Jan 17, 2025
cb45b08
Merge branch 'main' into bug/linux-rename-working-dir
vsbharath Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cumulusci/tasks/bulkdata/snowfakery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,8 +583,10 @@ def _generate_and_load_initial_batch(self, working_directory: Path):
self.sets_finished_while_generating_template = num_records

new_template_dir = data_loader_new_directory_name(template_dir, self.run_until)
shutil.move(template_dir, new_template_dir)
template_dir = new_template_dir
# rename only if new_template_dir does not match template_dir
if template_dir.resolve() != new_template_dir.resolve():
shutil.move(template_dir, new_template_dir)
template_dir = new_template_dir

# don't send data tables to child processes. All they
# care about are ID->OID mappings
Expand Down
Loading