Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAH-1672 New Translations for Educator Listings and Veterans Preferences #2032

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

jimlin-sfgov
Copy link
Collaborator

@jimlin-sfgov jimlin-sfgov commented Dec 13, 2023

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2032 December 13, 2023 01:24 Inactive
@jimlin-sfgov jimlin-sfgov force-pushed the DAH-1672-translations-educator-and-vet-pref branch from 5ab6a1d to 161cc91 Compare December 13, 2023 01:26
@jimlin-sfgov jimlin-sfgov temporarily deployed to dahlia-webapp-pr-2032 December 13, 2023 01:26 Inactive
@jimlin-sfgov jimlin-sfgov force-pushed the DAH-1672-translations-educator-and-vet-pref branch from 161cc91 to afc4a04 Compare December 13, 2023 17:44
@jimlin-sfgov jimlin-sfgov temporarily deployed to dahlia-webapp-pr-2032 December 13, 2023 17:44 Inactive
@jimlin-sfgov jimlin-sfgov added needs review Pull request needs review and removed WIP labels Dec 13, 2023
@jimlin-sfgov jimlin-sfgov marked this pull request as ready for review December 13, 2023 18:30
@@ -454,7 +488,7 @@
"not_found_body": "Estimado(a) MOHCD, no puedo completar mi solicitud para {{listing_name}}. Mi dirección es {{home_address}} y el formulario me señala que hay un error. Indíqueme qué puedo hacer a continuación. Gracias, {{first_name}} {{last_name}} {{email}} {{phone_number}}",
"not_found_subject": "No puedo ingresar mi dirección en la solicitud en DAHLIA"
},
"address_validation_duplicate_unit": "Si tiene un número de unidad o departamento, simplemente ingréselo en el casillero Apt or Unit # (N.° de departamento o unidad)",
"address_validation_duplicate_unit": "Si tiene un número de unidad o departamento, simplemente ingréselo en el casillero \"Apt or Unit #\" (N.° de departamento o unidad).",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 3 translations keys that are not related to Educator listings or Veteran preferences, but they were part of the translation files we received from Lionbridge.

Copy link
Contributor

@tallulahkay tallulahkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jimlin-sfgov jimlin-sfgov merged commit ef9e849 into main Dec 13, 2023
13 checks passed
@jimlin-sfgov jimlin-sfgov deleted the DAH-1672-translations-educator-and-vet-pref branch December 13, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Pull request needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants