Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

Classinated lidar.py, worldview.py #126

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Classinated lidar.py, worldview.py #126

merged 3 commits into from
Apr 10, 2024

Conversation

RK22000
Copy link
Collaborator

@RK22000 RK22000 commented Apr 6, 2024

Made lidar.py into a class. Tested it against the lidar visualizer.

  1. This is a step toward making everything into classes for a cleaner code.

Don't delete the branch after merging

@RK22000 RK22000 requested a review from chrehall68 April 6, 2024 23:33
@RK22000
Copy link
Collaborator Author

RK22000 commented Apr 6, 2024

Actually go ahead and delete it after merging I'll classify the next file on a new branch.

@RK22000 RK22000 changed the title Classinated lidar.py Classinated lidar.py, worldview.py Apr 7, 2024
@RK22000
Copy link
Collaborator Author

RK22000 commented Apr 7, 2024

Hey Eliot,
I'm thinking we don't need to make pathfinder into a class yet. pathfinder.py is literally just one function to get a navigator.
Instead look at #127 . I think that's a better way to clean up this situation

As of the latest commit, pathfinder_visuallizer.py works good. I havent yet checked captain,py

Copy link
Collaborator

@chrehall68 chrehall68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this looks great! Thanks for cleaning things up into classes! This really helps make the code manageable and readable!

@chrehall68 chrehall68 merged commit 7558971 into dev Apr 10, 2024
1 check passed
@chrehall68 chrehall68 deleted the TheClassinator3000 branch April 10, 2024 03:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants