Add operation with wedge to ease the representation of the topology of core mesh, with wedges to handle attribs. #589

dlyr · 2020-07-09T22:56:53Z

Please check if the PR fulfills these requirements

First part of this PR has been moved to #595 (add quad meshes for Core and Engine).
Second part of this PR has been moved to #719 (add wedge collapse).

Next steps, sorted by decreasing priority:

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Add operation with wedge to ease the representation of the topology of core mesh, with wedges to handle attribs.

nmellado

Nice !

src/Core/Geometry/TriangleMesh.hpp

MathiasPaulin

Nice first shot. Some improvements suggested.

src/Core/Geometry/TriangleMesh.hpp

src/Engine/Renderer/Mesh/Mesh.inl

MathiasPaulin · 2020-07-10T17:20:58Z

@nmellado the answer to your question about impact of degenerated triangles on rendering is on the picture post by @dlyr.
Seen from here, I'm sure there is no T vertices on the polymesh and everything is well done. clap clap @dlyr. But I think there are degenerated triangles along the horizontal edge just abode the bottom. If, instead of rendering flat color, you have to interpolate attributes to compute smooth shading, you'll have interpolation artifacts along that edges. degenerated triangles will be removed by the rasterizer and you will see discontinuity in the attribute interpolation.

dlyr · 2020-07-10T20:48:52Z

This kind of artifact.

Note that it is also present in "simple quads" and are not linked to degenerated triangles, just to thin triangles as seen here:

MathiasPaulin · 2020-07-11T08:55:39Z

Thin triangles are bad for rendering. More than computation precisions that degrade as the triangles become thin, the most proeminent problem relies to interpolation along the triangles in a mesh : piecewise linear approximation of non linear function over the mesh exhibit large errors and continuity issues. That's why a good mesh for rendering is a mesh that maximise the minimum triangle area and that maximise also the minimum internal angle on the triangle mesh (Delaunay triangulation does this).

nmellado · 2020-07-20T08:04:03Z

PolyMesh loading has been tested using this file: cube_quads.zip

First step of QuadMesh Remaining steps: #589

nmellado · 2020-07-23T07:01:39Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 4
           

Clones added
============
- tests/unittest/Core/topomesh.cpp  3
- tests/ExampleApps/DrawPrimitivesApp/minimalradium.cpp  3
         

Clones removed
==============
+ src/Core/Geometry/TopologicalMesh.hpp  -10
+ src/Core/Geometry/TopologicalMesh.cpp  -10

See the complete overview on Codacy

nmellado · 2020-07-23T07:01:48Z

tests/unittest/Core/topomesh.cpp

+    auto quad = VectorNui( 4 );
+    quad << 0, 1, 2, 3;
+    auto hepta = VectorNui( 7 );
+    hepta << 3, 2, 4, 5, 6, 7, 8;


Codacy found an issue: Found suspicious operator ','

tests/unittest/Core/topomesh.cpp

need new helpers function.

[tests] topo clean test naming. [tests] add wedge management tests, wip to triangulate. [tests] Add topo triangulate. [tests] newWedgeData(he). [tests] topo unit tests check integrity of triangulated.

core topo use modified version from open mesh collapse. move to collapse internal to private collapse fix loop wedge. detect feature for collapse.

MathiasPaulin · 2021-04-01T20:25:29Z

Is this draft PR still needed ?

dlyr · 2021-04-01T20:32:25Z

yes, there is all the TODO's to do

dlyr added Core Related to Ra::Core Engine Related to Ra::Engine enhancement Type of issue/PR: enhancement Feature Request Type of issue: feature request WIP Work in Progress labels Jul 9, 2020

dlyr requested review from nmellado, loicbarthe and MathiasPaulin July 9, 2020 23:02

dlyr force-pushed the quad-mesh branch from 802f7a4 to 2df8870 Compare July 9, 2020 23:03

dlyr marked this pull request as draft July 9, 2020 23:03

dlyr added the High priority label Jul 9, 2020

nmellado reviewed Jul 10, 2020

View reviewed changes

src/Core/Geometry/TriangleMesh.hpp Outdated Show resolved Hide resolved

MathiasPaulin reviewed Jul 10, 2020

View reviewed changes

src/Core/Geometry/TriangleMesh.hpp Outdated Show resolved Hide resolved

src/Engine/Renderer/Mesh/Mesh.inl Outdated Show resolved Hide resolved

MathiasPaulin reviewed Jul 10, 2020

View reviewed changes

src/Engine/Renderer/Mesh/Mesh.inl Outdated Show resolved Hide resolved

STORM-IRIT deleted a comment from nmellado Jul 10, 2020

STORM-IRIT deleted a comment from dlyr Jul 10, 2020

dlyr changed the title ~~Quad mesh~~ Quad/poly meshes Jul 12, 2020

STORM-IRIT deleted a comment from dlyr Jul 15, 2020

dlyr mentioned this pull request Jul 22, 2020

First step of QuadMesh #595

Merged

6 tasks

dlyr force-pushed the quad-mesh branch 2 times, most recently from 7258033 to b10dcbc Compare July 22, 2020 15:46

nmellado added a commit that referenced this pull request Jul 23, 2020

Merge pull request #595 from dlyr/geom-quad-mesh

e511722

First step of QuadMesh Remaining steps: #589

dlyr force-pushed the quad-mesh branch from b10dcbc to 45fb56f Compare July 23, 2020 06:59

nmellado reviewed Jul 23, 2020

View reviewed changes

tests/unittest/Core/topomesh.cpp Show resolved Hide resolved

dlyr added 15 commits March 17, 2021 17:16

[core] Topo reorganize declarations (hpp/inl).

13f1086

[core] remove deprecated unused using decl.

edf8fbf

[core] rename addProp to addAttrib form wedge collection.

b5de901

[core] rename setWedgeData to setWedgeAttrib to set one attrib.

e5d96a0

[core] more deprecation, is "mostly" handled by wedges,

be82741

need new helpers function.

[core] topo remove omp parallel for (windows error)

7d7e161

[core] topo add newWedge function and some aliases.

1816741

[core] topo improve newWedgeData.

a7161c8

[tests] call splitEdge instead of alias splitEdgeWedge.

2825c78

[tests] topo clean test naming. [tests] add wedge management tests, wip to triangulate. [tests] Add topo triangulate. [tests] newWedgeData(he). [tests] topo unit tests check integrity of triangulated.

[core] More checks in topo integrity.

0a620c0

[core] Add topo triangulate fixup.

f24e7d8

[core] Topo to line Mesh.

47d0b99

[core] fix topo wedge collapse

7e52f7e

core topo use modified version from open mesh collapse. move to collapse internal to private collapse fix loop wedge. detect feature for collapse.

[core] fix mergeEqualWedge for boundaries.

df3f087

[core] rename addWedgeData to addWedgeAttrib, when one attrib only.

f36f6e3

dlyr force-pushed the quad-mesh branch from 7176009 to 08a0485 Compare March 17, 2021 16:16

dlyr added 7 commits March 17, 2021 17:39

[core] clean and add deprecated.

4c930bc

[tests] wip topo merge unit test

b479e8f

[tests] update topo collapse unittest.

2bff2b6

[tests] Draw primitive triangulate, and remove degen faces.

8b2c7ac

[tests] draw prim wedge collapse

3a988b9

[tests] DrawPrimitives more examples of collapse.

2589dce

[tests] Update DrawPrimitive for collapse.

4a1be9c

dlyr force-pushed the quad-mesh branch from 08a0485 to 4a1be9c Compare March 17, 2021 16:41

dlyr mentioned this pull request Mar 17, 2021

TopologicalMesh Wedge's round 2. #719

Merged

3 tasks

dlyr force-pushed the master branch from 480d276 to 7d39d7a Compare September 14, 2022 12:31

dlyr changed the base branch from master to release-candidate September 21, 2022 12:04

dlyr changed the title ~~Quad/poly meshes~~ Add operation with wedge to ease the representation of the topology of core mesh, with wedges to handle attribs. Sep 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add operation with wedge to ease the representation of the topology of core mesh, with wedges to handle attribs. #589

Add operation with wedge to ease the representation of the topology of core mesh, with wedges to handle attribs. #589

dlyr commented Jul 9, 2020 •

edited

Loading

nmellado left a comment

MathiasPaulin left a comment

MathiasPaulin commented Jul 10, 2020

dlyr commented Jul 10, 2020

MathiasPaulin commented Jul 11, 2020

nmellado commented Jul 20, 2020

nmellado commented Jul 23, 2020

nmellado Jul 23, 2020

MathiasPaulin commented Apr 1, 2021

dlyr commented Apr 1, 2021

Add operation with wedge to ease the representation of the topology of core mesh, with wedges to handle attribs. #589

Are you sure you want to change the base?

Add operation with wedge to ease the representation of the topology of core mesh, with wedges to handle attribs. #589

Conversation

dlyr commented Jul 9, 2020 • edited Loading

nmellado left a comment

Choose a reason for hiding this comment

MathiasPaulin left a comment

Choose a reason for hiding this comment

MathiasPaulin commented Jul 10, 2020

dlyr commented Jul 10, 2020

MathiasPaulin commented Jul 11, 2020

nmellado commented Jul 20, 2020

nmellado commented Jul 23, 2020

nmellado Jul 23, 2020

Choose a reason for hiding this comment

MathiasPaulin commented Apr 1, 2021

dlyr commented Apr 1, 2021

dlyr commented Jul 9, 2020 •

edited

Loading