First step of QuadMesh #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlyr
added
Core
10 tasks
* and some spacing. * triangulate using sewing.
Since clang-format is now added to git repo, do not create a symlink.
Solve test depends on uninit value (displayed by valgrind).
As kitten died when I copy paste this code ... without changing the test.
Replace TriangleMeshComponent by a template class SurfaceMeshComponent Define TriangleMeshComponent as SurfaceMeshComponent<TriangleMesh> Update SurfaceMeshComponent to support Polygonal Meshes.
Indices are used by setFaces.
|
Issues
======
- Added 4
Clones removed
==============
+ src/Engine/Component/GeometryComponent.cpp -6
See the complete overview on Codacy |
nmellado
reviewed
Jul 22, 2020
| auto hepta = VectorNui( 7 ); | ||
| hepta << 3, 2, 4, 5, 6, 7, 8; | ||
| auto degen = VectorNui( 10 ); | ||
| degen << 1, 0, 9, 10, 11, 12, 13, 14, 15, 16; |
There was a problem hiding this comment.
Codacy found an issue: Found suspicious operator ','
nmellado
reviewed
Jul 22, 2020
| polyMesh.setNormals( normals ); | ||
|
|
||
| auto quad = VectorNui( 4 ); | ||
| quad << 0, 1, 2, 3; |
There was a problem hiding this comment.
Codacy found an issue: Found suspicious operator ','
nmellado
reviewed
Jul 22, 2020
| auto degen = VectorNui( 10 ); | ||
| degen << 1, 0, 9, 10, 11, 12, 13, 14, 15, 16; | ||
| auto degen2 = VectorNui( 10 ); | ||
| degen2 << 14, 13, 12, 11, 10, 9, 17, 18, 16, 15; |
There was a problem hiding this comment.
Codacy found an issue: Found suspicious operator ','
nmellado
reviewed
Jul 22, 2020
| auto quad = VectorNui( 4 ); | ||
| quad << 0, 1, 2, 3; | ||
| auto hepta = VectorNui( 7 ); | ||
| hepta << 3, 2, 4, 5, 6, 7, 8; |
There was a problem hiding this comment.
Codacy found an issue: Found suspicious operator ','
nmellado
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corresponds to the addition of Core and Engine QuadMesh.
Tological mesh is not yet supported.
See #589 for discussion and details.
here from top to bottom, heptagone, quad, and two degenerated (align points, equal points) decagon
PolyMeshwhen required