New proposal for Engine::Displayable #802
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmellado
added
enhancement
Codecov Report
@@ Coverage Diff @@
## release-candidate #802 +/- ##
=====================================================
+ Coverage 45.65% 46.01% +0.35%
=====================================================
Files 312 311 -1
Lines 23060 23101 +41
=====================================================
+ Hits 10529 10630 +101
+ Misses 12531 12471 -60
|
nmellado
force-pushed
the
clean_displayable
branch
2 times, most recently
from
5a16cbe
to
fa260e4
Compare
nmellado
force-pushed
the
clean_displayable
branch
from
3aa14e1
to
629f408
Compare
dlyr
force-pushed
the
clean_displayable
branch
2 times, most recently
from
757a5e9
to
1e88873
Compare
dlyr
force-pushed
the
clean_displayable
branch
2 times, most recently
from
d2bf2c5
to
2d148ca
Compare
dlyr
added
Core
dlyr
force-pushed
the
clean_displayable
branch
from
12af541
to
2fff241
Compare
nmellado
force-pushed
the
clean_displayable
branch
from
435c672
to
60b8cdf
Compare
|
note for futur skinning https://cims.nyu.edu/gcl/papers/EG2014-Lighting.pdf |
dlyr
force-pushed
the
clean_displayable
branch
from
8947bd5
to
8f5a25f
Compare
dlyr
force-pushed
the
clean_displayable
branch
2 times, most recently
from
cdf9736
to
f5df674
Compare
[core] Expose LayerKeyHash struct Allow to reuse layers hash function outside of MultiIndexedGeometry
[engine] Remove unused class IndexedAttribArrayDisplayable [engine] Prepare classes attributes (do not compile) Code does not compile as only the attributes have been defined, but the methods have not been updated. [core] Mark GeometryIndexLayerBase::size() as const [engine] define all virtual function for GeometryDisplayable (will be deleted). When transition will be complete, these accessor might not be necessary. [engine] GeometryDisplayable updateGL (not tested). [engine] GeometryDisplayable works, for HelloRadium. triangulate
debug type clone make clone everywhere
clean code with using forward renderer handle poly and quad layers.
merge for GeometryDisplayable.
[engine] mesh override getNumVertices for GeometryDisplayable. remove uneeded export api on template
remove forward old draw wireframe
[engine] Mesh remove debug print. remove mesh debug message print mesh name on invalid layer
tmp disable rotation center skinning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Simplify API for
Engine::Displayableand inheriting classes by usingCore::MultiIndexGeometry.What is the current behavior? (You can also link to an open issue here)
Mesh types are statically typed on Core Mesh types.
What is the new behavior (if this is a feature change)?
Take benefit of
MultiIndexGeometryto allow dynamic typing of the rendered objects:Engine::GeometryDisplayablewill store a collection of geometry layers.Expected API (right):
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Will impact client code explicitly working with
Engine::Displayableand inhering classes.Other information: