Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New proposal for Engine::Displayable #802

Open
wants to merge 28 commits into
base: release-candidate
Choose a base branch
from
Open

New proposal for Engine::Displayable #802

wants to merge 28 commits into from

Commits on Apr 7, 2023

  1. [core] Fix IndexedGeometry. 

    [core] Expose LayerKeyHash struct

Allow to reuse layers hash function outside of MultiIndexedGeometry
    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    5fb8ebc View commit details
    Browse the repository at this point in the history

  2. [engine] Prepare API of GeometryDisplayable 

    [engine] Remove unused class IndexedAttribArrayDisplayable

[engine] Prepare classes attributes (do not compile)

Code does not compile as only the attributes have been defined, but the
methods have not been updated.

[core] Mark GeometryIndexLayerBase::size() as const

[engine] define all virtual function for GeometryDisplayable (will be deleted).

When transition will be complete, these accessor might not be necessary.

[engine] GeometryDisplayable updateGL (not tested).

[engine] GeometryDisplayable works, for HelloRadium.

triangulate
    @nmellado @dlyr
    nmellado authored and dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    8de3a11 View commit details
    Browse the repository at this point in the history

  3. [engine] add GeometryDisplayableComponent

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    6689dde View commit details
    Browse the repository at this point in the history

  4. [tests] Use GeometryDisplayableComponent in HelloRadium (nothing draw… 

    …n yet).
    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    1a86723 View commit details
    Browse the repository at this point in the history

  5. [core] Switch struct -> class for AbstractGeometry.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    ec4057a View commit details
    Browse the repository at this point in the history

  6. [core] Use macro for clone implementation. 

    debug type clone

make clone everywhere
    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    d020cea View commit details
    Browse the repository at this point in the history

  7. [engine] double wireframe (ad hoc for quad mesh). 

    clean code with using

forward renderer handle poly and quad layers.
    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    7ed8468 View commit details
    Browse the repository at this point in the history

  8. [core][engine] Use demangleType.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    509d68b View commit details
    Browse the repository at this point in the history

  9. [engine] user BijectiveAssociation for translation table. 

    merge for GeometryDisplayable.
    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    a5aa861 View commit details
    Browse the repository at this point in the history

  10. [core][engine] Move triangulate to core.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    df8275e View commit details
    Browse the repository at this point in the history

  11. [engine] Add empty ctor.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    0a6f878 View commit details
    Browse the repository at this point in the history

  12. [engine] use geometrydisplayable for components.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    2a1e9a4 View commit details
    Browse the repository at this point in the history

  13. [engine] rename correspondance -> matching 

    [engine] mesh override getNumVertices for GeometryDisplayable.

remove uneeded export api on template
    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    6f05270 View commit details
    Browse the repository at this point in the history

  14. [engine] GeometrySystem use GeometryDisplayable comp.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    9d879cf View commit details
    Browse the repository at this point in the history

  15. [examples] Start using GeometryDisplayable in draw prim.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    eced115 View commit details
    Browse the repository at this point in the history

  16. [engine] GeometryComponent clean include.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    b58b111 View commit details
    Browse the repository at this point in the history

  17. [engine] Renderer remove debug print. 

    remove forward old draw wireframe
    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    85ea8dd View commit details
    Browse the repository at this point in the history

  18. [engine] handle line index layer picking render mode. 

    [engine] Mesh remove debug print.

remove mesh debug message

 print mesh name on invalid layer
    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    c5b1275 View commit details
    Browse the repository at this point in the history

  19. [core] MeshPrimitives remove debug print.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    0c04358 View commit details
    Browse the repository at this point in the history

  20. [core] IndexedGeometry remove debug print.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    eb21bbd View commit details
    Browse the repository at this point in the history

  21. [examples] HelloRadium remove debug print.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    a8168ef View commit details
    Browse the repository at this point in the history

  22. [engine] Remove unused LineMeshComponent.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    ba7e3ce View commit details
    Browse the repository at this point in the history

  23. [examples] add fixed light in skinning example.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    8304bdb View commit details
    Browse the repository at this point in the history

  24. [core] use inverse transpose for normal lbs.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    d61b0cc View commit details
    Browse the repository at this point in the history

  25. [core] comment typo in trianglemesh

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    ade232c View commit details
    Browse the repository at this point in the history

  26. [core][engine] use AttribArrayGeometry as skinning data. 

    tmp disable rotation center skinning
    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    c4647b2 View commit details
    Browse the repository at this point in the history

  27. [core] register rw on AttribArrayGeometry for SurfaceMeshComponent.

    @dlyr
    dlyr committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    e9f3e16 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. remove temporary non working code

    @dlyr
    dlyr committed May 16, 2023
    Configuration menu
    Copy the full SHA
    076ec5e View commit details
    Browse the repository at this point in the history