Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected env docs; generate env var docs based on opts-specs #346

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

mdemare
Copy link
Collaborator

@mdemare mdemare commented Dec 6, 2024

  • Fixed docs
  • Generate env var docs from opts-specs (single source of truth)
  • STORE_HTTP_REQUESTS should use opts-specs

@mdemare mdemare marked this pull request as ready for review December 7, 2024 11:17
@mdemare mdemare requested review from joodie and remvee December 9, 2024 14:28
@mdemare
Copy link
Collaborator Author

mdemare commented Dec 9, 2024

Zie ook patch voor env-opts met boolean support

src/nl/surf/eduhub_rio_mapper/config.clj Outdated Show resolved Hide resolved
src/nl/surf/eduhub_rio_mapper/cli_commands.clj Outdated Show resolved Hide resolved
Copy link
Collaborator

@remvee remvee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemare mdemare merged commit e3357b6 into main Dec 10, 2024
6 checks passed
@mdemare mdemare deleted the docs branch December 10, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants