-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup codebase #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I'll let rixing do another review, but this looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a couple comments.
If any of the unused features plan to be included as part of this ticket, might be worthwhile moving them into a TODO README or leaving them there but adding TODO comments, thoughts?
modules/minerva.nf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comments as the above. They are referenced here.
Simplify output
…amplesheet Use id column from samplesheet if specified
@rxu17 @tom Thanks for looking over. I've made a number of further changes.
I've been using these features (in the |
From the legacy htan-artist repo there are a number of half-developed or unused features in the codebase.
This PR removes these to allow our main branch to only include used and functional features.