AG-1346 GCT bug fix for zero p-values showing wrong circle size #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagely1
commented
Feb 12, 2024
|
|
||
| if (tissue?.adj_p_val) { | ||
| size = this.getCircleSize(tissue.adj_p_val); | ||
| } | ||
|
|
||
| if (size === 0) { |
There was a problem hiding this comment.
if circle size is zero, it should have the max size of circle as the p-value is inversely proportional to the size of the circle.
hallieswan
reviewed
Feb 13, 2024
src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.ts
Outdated
Show resolved
Hide resolved
sagely1
commented
Feb 19, 2024
src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.ts
Show resolved
Hide resolved
sagely1
commented
Feb 19, 2024
src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.ts
Show resolved
Hide resolved
sagely1
commented
Feb 19, 2024
src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.ts
Show resolved
Hide resolved
hallieswan
reviewed
Feb 19, 2024
Comment on lines
1022
to
1032
| tissue ? tissue.logfc : '', | ||
| tissue ? tissue.ci_r : '', | ||
| tissue ? tissue.ci_l : '', | ||
| tissue ? tissue.adj_p_val : '', | ||
| tissue?.logfc || '', | ||
| tissue?.ci_r || '', | ||
| tissue?.ci_l || '', | ||
| tissue?.adj_p_val || '', |
There was a problem hiding this comment.
Was this change intentional? It looks like this may reintroduce the bug fixed in AG-1347
There was a problem hiding this comment.
Good catch! Not sure why this change didn't merge from AG-1347 but I committed it.
hallieswan
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.