Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AG-1346 GCT bug fix for zero p-values showing wrong circle size #1282

Merged
merged 6 commits into from
Feb 27, 2024
Merged

AG-1346 GCT bug fix for zero p-values showing wrong circle size #1282

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8dd4164
AG-1346 GCT bug fix for zero p-values showing wrong circle size
sagely1 Feb 12, 2024
76d4ab7
Merge branch 'develop' into AG-1346-gct-does-not-display-circles-when…
sagely1 Feb 13, 2024
16bcff2
AG-1346 refactor to provide more clarity. Note: circle scaling has b…
sagely1 Feb 15, 2024
6b482b6
Merge branch 'develop' into AG-1346-gct-does-not-display-circles-when…
sagely1 Feb 27, 2024
be167d9
Merge branch 'develop' into AG-1346-gct-does-not-display-circles-when…
sagely1 Feb 27, 2024
8df5b99
AG-1346 - merging changes from AG-1347
sagely1 Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,15 +912,20 @@ export class GeneComparisonToolComponent implements OnInit, AVI, OnDestroy {
const tissue = gene.tissues.find((t) => t.name === tissueName);
let size = 0;
sagely1 marked this conversation as resolved.
Show resolved Hide resolved
let color = '#F0F0F0';
const CIRCLE_MAX_SIZE = 50;

if (tissue?.adj_p_val) {
size = this.getCircleSize(tissue.adj_p_val);
}

if (size === 0) {
Copy link
Contributor Author

@sagely1 sagely1 Feb 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if circle size is zero, it should have the max size of circle as the p-value is inversely proportional to the size of the circle.

size = CIRCLE_MAX_SIZE;
}
sagely1 marked this conversation as resolved.
Show resolved Hide resolved

if (tissue?.logfc) {
color = this.getCircleColor(tissue.logfc);
}

return {
display: size ? 'block' : 'none',
width: size + 'px',
Expand Down
Loading