AG-1398 Fix for bug with pValues not showing when value is zero #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagely1
commented
Mar 20, 2024
| @@ -15,11 +15,11 @@ | |||
| <div class="gct-details-panel-data"> | |||
| <div> | |||
| <div>{{ data.valueLabel }}</div> | |||
| <div *ngIf="data.pValue">P-Value</div> | |||
There was a problem hiding this comment.
In cases when this variable was zero, the div and value below would not show.
sagely1
commented
Mar 20, 2024
| @@ -96,6 +96,9 @@ export class GeneComparisonToolDetailsPanelComponent { | |||
| } | |||
|
|
|||
| getSignificantFigures(n: any, b: any) { | |||
| const emdash = '—'; // Shift+Option+Hyphen | |||
There was a problem hiding this comment.
emdash is being used to visually expose missing data.
There was a problem hiding this comment.
A future update will move this into a custom pipe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.