Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AG-1398 Fix for bug with pValues not showing when value is zero #1293

Merged
merged 1 commit into from
Mar 21, 2024
Merged

AG-1398 Fix for bug with pValues not showing when value is zero #1293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ents/gene-comparison-tool-details-panel/gene-comparison-tool-details-panel.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@
<div class="gct-details-panel-data">
<div>
<div>{{ data.valueLabel }}</div>
<div *ngIf="data.pValue">P-Value</div>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In cases when this variable was zero, the div and value below would not show.

<div>P-Value</div>
</div>
<div>
<div>{{ getSignificantFigures(data.value, 3) }}</div>
<div *ngIf="data.pValue">
<div>
{{ getSignificantFigures(data.pValue, 3) }}
</div>
</div>
Expand Down
3 changes: 3 additions & 0 deletions ...onents/gene-comparison-tool-details-panel/gene-comparison-tool-details-panel.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ export class GeneComparisonToolDetailsPanelComponent {
}

getSignificantFigures(n: any, b: any) {
const emdash = '&#8212;'; // Shift+Option+Hyphen
Copy link
Contributor Author

@sagely1 sagely1 Mar 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emdash is being used to visually expose missing data.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A future update will move this into a custom pipe

if (n === null || n === undefined)
return emdash;
return this.helperService.getSignificantFigures(n, b);
}

Expand Down
Loading