Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openchallenges): add temporal information to challenge card #2277

Merged
merged 15 commits into from
Nov 2, 2023

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Oct 26, 2023

Fixes #2240

Changelog

  • add logic for calculating time difference in units of years, months, weeks, days, and hours
  • display time until start date OR time until end date (depending on status), using the largest non-zero time unit
  • due to limited space in the footer: re-arrange the card layout, switching placements of status and platform
  • update "Incentives" icon to something more obvious (trophy)
  • add fixed heights for status and headline divs; that way, cards stay uniformed in height no matter the contents

Preview

Footer icons using the same color:

Screenshot 2023-10-26 at 12 31 22 AM

OR one footer icon uses the blue color from our logo and one icon uses the other:

Screenshot 2023-10-26 at 4 49 56 PM

Alternatively, we can forgo displaying the platform altogether (something Addison mentioned as potentially not helpful information):

Screenshot 2023-10-26 at 12 44 12 AM

@vpchung vpchung self-assigned this Oct 26, 2023
@vpchung
Copy link
Member Author

vpchung commented Oct 27, 2023

Latest iteration:

Screenshot 2023-10-27 at 2 07 44 PM

@tschaffter
Copy link
Member

tschaffter commented Oct 27, 2023

@vpchung "Completed" in red could be reminiscent of errors to users. What about using the default (black) color for completed challenges?

@tschaffter
Copy link
Member

tschaffter commented Oct 27, 2023

Another suggestion would be to hide time information for challenges that have no longer been "recently" completed (3 mo ago?). When I see "10 years ago" I may think to "last updated 10 years ago". This does not have a positive connotation.

@vpchung
Copy link
Member Author

vpchung commented Oct 27, 2023

Black color for completed status; show all timeSince info

Screenshot 2023-10-27 at 2 42 25 PM

Black color for completed status; hide timeSince info older than 3 months

Screenshot 2023-10-27 at 2 50 37 PM

Colorized completed status; hide timeSince info older than 3 months

Screenshot 2023-10-27 at 2 50 58 PM

@vpchung
Copy link
Member Author

vpchung commented Oct 27, 2023

I'm not a big fan of the default color for the Completed status, but I can also see your point about red = error. What do you think about using our primary color (blue) instead?

Screenshot 2023-10-27 at 2 55 33 PM

@tschaffter
Copy link
Member

tschaffter commented Oct 27, 2023

@vpchung Why are you not a fan of the default color for completed challenges?

@vpchung
Copy link
Member Author

vpchung commented Oct 30, 2023

For me, it lacks consistency - either all statuses should be a different color from the default text color, or they should all be the same.

@tschaffter
Copy link
Member

@vpchung Thanks for the insight. I understand this viewpoint. I gave some thought about this and I think that the new status style capture more the attention that previously. The two reasons are that this information is now at the center of the card and that it's more colorful compared to the solution with the colored dot. With the proposed design, I think that I'm looking first at the status, then at the title. I think that this may disrupt the flow of reading that should be from top to bottom - or at least the title should be read first? Maybe my eyes are attracted to the status first because it's the topic of this PR...

Could we ask Adam to review the current proposal for the card?

@vpchung What do you think about hiding the platform information from the card? Did you mention on Friday that Addison suggested this too? The two reasons that prompt me to suggest this change are: 1) we know that the challenge ecosystem and information are fragmented by benchmarking communities and platforms. Removing this information from the card could be a way for us to "mend" this fragmentation to some extend if that makes sense. 2) enable the user to read more challenge cards by removing some information from the card.

@vpchung
Copy link
Member Author

vpchung commented Oct 30, 2023

With the proposed design, I think that I'm looking first at the status, then at the title... this may disrupt the flow of reading that should be from top to bottom

Ah yes, I can see that. I can try going back to the bullet design.

What do you think about hiding the platform information from the card? Did you mention on Friday that Addison suggested this too?

Yes! A design proposal for this is given in the original comment here (third screenshot). I can continue working off of that iteration.

@vpchung
Copy link
Member Author

vpchung commented Oct 30, 2023

Latest iteration

Original bullet size
Screenshot 2023-10-30 at 11 24 34 AM

Slightly bigger bullet size
Screenshot 2023-10-30 at 11 27 50 AM

Extra big bullet size 😆
Screenshot 2023-10-30 at 11 26 00 AM

@tschaffter
Copy link
Member

I like the "Slightly bigger bullet size" design.

@vpchung
Copy link
Member Author

vpchung commented Oct 30, 2023

PR is now ready for (re-)review.

@vpchung
Copy link
Member Author

vpchung commented Nov 1, 2023

Thank you, @rrchai , for pointing out the inconsistency of the status colors during the standup. I have addressed the issue with the following design options:

Complete as red

Profile Card
Screenshot 2023-11-01 at 12 22 11 PM Screenshot 2023-11-01 at 12 22 20 PM

Complete as blue

Profile Card
Screenshot 2023-11-01 at 12 24 17 PM Screenshot 2023-11-01 at 12 24 28 PM

Note that above, I changed the status color on the profile pages from black to red/blue. The original design is black text, i.e.

Screenshot 2023-11-01 at 12 35 54 PM

Screenshot 2023-11-01 at 12 35 24 PM

@vpchung
Copy link
Member Author

vpchung commented Nov 1, 2023

Moving forward with blue for "Completed" status. As a safe measure, I also simulated the updated status colors with Coblis and WebAIM to verify that this change is still accessible to users with color-blindness (they passed, according to the simulators).

Challenge card
Screenshot 2023-11-01 at 3 18 29 PM

Challenge profile
Screenshot 2023-11-01 at 3 18 36 PM

@vpchung vpchung requested a review from tschaffter November 1, 2023 22:17
@rrchai
Copy link
Contributor

rrchai commented Nov 1, 2023

LGTM with one small suggestion. Since the status has a circle before the text, align-center might not perfectly align the status box with "ends/starts ..." box in center. Adding some margin-left on status box to move a bit toward left can make alignment better in my oppinion.

Before

Screen Shot 2023-11-01 at 6 49 59 PM

After moving status box to left by 8px

Screen Shot 2023-11-01 at 6 49 43 PM

@vpchung vpchung merged commit 7ae8482 into Sage-Bionetworks:main Nov 2, 2023
6 checks passed
@vpchung vpchung deleted the task-2240 branch November 2, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add temporal information to the challenge card ⭐
3 participants