-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openchallenges): add temporal information to challenge card #2277
Conversation
@vpchung "Completed" in red could be reminiscent of errors to users. What about using the default (black) color for completed challenges? |
Another suggestion would be to hide time information for challenges that have no longer been "recently" completed (3 mo ago?). When I see "10 years ago" I may think to "last updated 10 years ago". This does not have a positive connotation. |
@vpchung Why are you not a fan of the default color for completed challenges? |
For me, it lacks consistency - either all statuses should be a different color from the default text color, or they should all be the same. |
@vpchung Thanks for the insight. I understand this viewpoint. I gave some thought about this and I think that the new status style capture more the attention that previously. The two reasons are that this information is now at the center of the card and that it's more colorful compared to the solution with the colored dot. With the proposed design, I think that I'm looking first at the status, then at the title. I think that this may disrupt the flow of reading that should be from top to bottom - or at least the title should be read first? Maybe my eyes are attracted to the status first because it's the topic of this PR... Could we ask Adam to review the current proposal for the card? @vpchung What do you think about hiding the platform information from the card? Did you mention on Friday that Addison suggested this too? The two reasons that prompt me to suggest this change are: 1) we know that the challenge ecosystem and information are fragmented by benchmarking communities and platforms. Removing this information from the card could be a way for us to "mend" this fragmentation to some extend if that makes sense. 2) enable the user to read more challenge cards by removing some information from the card. |
Ah yes, I can see that. I can try going back to the bullet design.
Yes! A design proposal for this is given in the original comment here (third screenshot). I can continue working off of that iteration. |
I like the "Slightly bigger bullet size" design. |
PR is now ready for (re-)review. |
libs/openchallenges/ui/src/lib/challenge-card/challenge-card.component.ts
Show resolved
Hide resolved
libs/openchallenges/ui/src/lib/challenge-card/challenge-card.component.ts
Show resolved
Hide resolved
Thank you, @rrchai , for pointing out the inconsistency of the status colors during the standup. I have addressed the issue with the following design options: Complete as red
Complete as blue
Note that above, I changed the status color on the profile pages from black to red/blue. The original design is black text, i.e. |
Fixes #2240
Changelog
Preview
Footer icons using the same color:
OR one footer icon uses the blue color from our logo and one icon uses the other:
Alternatively, we can forgo displaying the platform altogether (something Addison mentioned as potentially not helpful information):