-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schematic): added synapse cache purging fds-1445 #2660
feat(schematic): added synapse cache purging fds-1445 #2660
Conversation
@jesusaurus This is the new Schematic API we are hoping to deploy soon, that would replace the old one. I undertsand that it was suggested by you in this PR, that the synapse cache be moved to "/var/tmp/synapse". Is that still valid? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried executing one of the endpoints and see if everything is working as expected? I tried executing: http://localhost:7443/api/v1/ui/#/Storage/get_manifest_csv,
and I got an error:
{
"detail": "local variable 'byte_size' referenced before assignment",
"status": 500,
"title": "Internal error"
}
But on schematic side, I tried:
store = SynapseStorage(
access_token="<my token>", synapse_cache_path="/var/tmp/synapse"
)
and it worked...
Do you have similar errors?
size_letter = size_string[-1] | ||
size = float(size_string[:-1]) | ||
multiple = 1024 ** size_dict[size_letter] | ||
byte_size: int = ceil(size * multiple) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an int, thats what the ceil function does.
apps/schematic/api/schematic_api/controllers/storage_controller_impl.py
Outdated
Show resolved
Hide resolved
apps/schematic/api/schematic_api/test/test_synapse_endpoints.py
Outdated
Show resolved
Hide resolved
@andrewelamb yeah, I still have a mild preference for |
I can't replicate this error |
apps/schematic/api/schematic_api/controllers/storage_controller_impl.py
Outdated
Show resolved
Hide resolved
Also, I think it worths noting some other changes that were made in the PR:
|
Quality Gate passed for 'schematic-api'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I think it looks good to me.
deault_config.yaml
for globalsdeault_config.yaml
can be overridden byconfig.yaml
file for settable globals/var/tmp/synapse
)