-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schematic): added synapse cache purging fds-1445 #2660
Merged
andrewelamb
merged 14 commits into
Sage-Bionetworks:main
from
andrewelamb:feature-cache-purging-fds-1445
May 9, 2024
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7334ecd
added synapse cache purging
andrewelamb 39db686
Merge remote-tracking branch 'upstream/main' into feature-cache-purgi…
andrewelamb 6b0ce65
added marks to new test
andrewelamb f8a77e9
Merge remote-tracking branch 'upstream/main' into HEAD
andrewelamb cbb32ae
updated module name and url for swagger ui url
andrewelamb 4fd4485
Linglings suggestions
andrewelamb 7e0736d
remove exception
andrewelamb feee117
Merge branch 'main' into feature-cache-purging-fds-1445
andrewelamb 6d420a1
separated config form test config
andrewelamb 4a77949
Merge branch 'feature-cache-purging-fds-1445' of https://github.com/a…
andrewelamb 890c7b4
add field to config for turning on and off purging
andrewelamb 7153266
added example synapse config file
andrewelamb 1c63b06
renamed example_config to default_config
andrewelamb 8ff8b34
renamed example_config to default_config
andrewelamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# If true, the synapse cache is purged before running a synapse storage related endpoint | ||
purge_synapse_cache: true | ||
# This can be set to a specific path, or to null to let the python client deicde | ||
synapse_cache_path: '/var/tmp/synapse' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an int, thats what the ceil function does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sorry for the previous comment. I just realized that this will be
int
But do we do inline typing like this? I think having int as return type is sufficient?