Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agora): migrate Agora to use shared boxplot component (AG-1460) #2956

Merged
merged 3 commits into from
Jan 10, 2025
Merged

feat(agora): migrate Agora to use shared boxplot component (AG-1460) #2956

merged 3 commits into from
Jan 10, 2025

Conversation

hallieswan
Copy link
Collaborator

@hallieswan hallieswan commented Jan 8, 2025 •
edited by jira bot
Loading

Description

Migrates Agora boxplots to use shared boxplot component.

Related Issue

Changelog

  • Migrates Agora boxplots to use shared boxplot component
  • Removes historic Agora boxplot component dependent on dc.js (AG-1179)
  • Adds shared Storybook for Agora libraries with proof of concept stories for Boxplot, About, and News components

Preview

Boxplot:

AG-1460_boxplot.mov

Comparison:

Plot Current Updated
Proteomics AG-1460_boxplot_protein_tooltip_develop AG-1460_boxplot_protein_tooltip_monorepo
RNA AG-1460_boxplot_rna_develop AG-1460_boxplot_rna_monorepo

Run shared storybook with nx run agora-storybook:storybook.
View at http://localhost:4400/:

AG-1460_agora_storybook

@hallieswan hallieswan marked this pull request as ready for review January 8, 2025 23:08
@hallieswan hallieswan requested review from tschaffter and a team as code owners January 8, 2025 23:08
@hallieswan hallieswan self-assigned this Jan 8, 2025
tschaffter
tschaffter reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@tschaffter tschaffter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The PR description, along with the preview one, is top-notch. I've shared a couple of comments.

.gitignore Outdated Show resolved Hide resolved
libs/agora/charts/src/lib/box-plot-chart/box-plot-chart.component.ts Outdated Show resolved Hide resolved
@hallieswan hallieswan requested a review from sagely1 January 10, 2025 01:15
@tschaffter tschaffter self-requested a review January 10, 2025 17:55
@tschaffter tschaffter merged commit 9597389 into Sage-Bionetworks:main Jan 10, 2025
12 of 13 checks passed
@hallieswan hallieswan deleted the agora/AG-1460 branch January 10, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschaffter tschaffter tschaffter approved these changes

@sagely1 sagely1 Awaiting requested review from sagely1

Assignees

@hallieswan hallieswan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hallieswan @tschaffter @sagely1