Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tflchef] Introduce a op util function to check custom codes #11813

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

Seunghui98
Copy link
Contributor

This introduces a function that check codes of CustomOp to avoid duplication.

ONE-DCO-1.0-Signed-off-by: SeungHui Lee [email protected]


Related Issue: #11741
Draft PR: #11750

@Seunghui98 Seunghui98 added the PR/ready for review It is ready to review. Please review it. label Oct 30, 2023
@Seunghui98
Copy link
Contributor Author

Seunghui98 commented Oct 30, 2023

Here is the related PR that came out first. -> #11785
There are many changes, so I split the PR.
After this PR is merged, the next ModelChef.cpp in tflchef will be reflect.

This introduces a function that check codes of CustomOp to avoid duplication.

ONE-DCO-1.0-Signed-off-by: SeungHui Lee <[email protected]>
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

Copy link
Contributor

@mhs4670go mhs4670go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 6eb9ec4 into Samsung:master Oct 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants