[tflchef] Use extype and custom_code type for custom operators #11785
Conversation
Seunghui98
added
the
PR/ready for review
Seunghui98
force-pushed
the
add_custom_op
branch
from
2959975 to
cf59238
Compare
Seunghui98
force-pushed
the
add_custom_op
branch
from
cf59238 to
859196a
Compare
| if ((operation.has_extype() && operation.extype() == "Custom") || | ||
| (operation.has_type() && operation.type() == "Custom")) | ||
| continue; |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
compiler/tflchef/core/src/OpChef.h
Outdated
| static void CheckCustomOp(const tflchef::Operation operation, std::string op_type) | ||
| { | ||
| if ((operation.has_extype() && operation.extype() == "Custom") || | ||
| (operation.has_type() && operation.type() == "Custom")) | ||
| { | ||
| assert(operation.has_custom_code()); | ||
| assert(operation.custom_code() == op_type); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
I created a function here to avoid duplication.
There was a problem hiding this comment.
Q) Can you explain more about what you mean by avoid duplication ?
|
As you(@seanshpark ) advised, I rewrote the code. |
compiler/tflchef/core/src/OpChef.h
Outdated
| @@ -45,4 +45,14 @@ struct OpChefFactory | |||
| virtual std::unique_ptr<OpChef> create(const tflchef::Operation *operation) const = 0; | |||
| }; | |||
|
|
|||
| static void CheckCustomOp(const tflchef::Operation operation, std::string op_type) | |||
There was a problem hiding this comment.
plz do not use static in header. there will be duplicate static functions across the callers.
There was a problem hiding this comment.
Could you advise me where it would be good...?
Please think of what the purpose of this function, and the scope of the functionality.
And looking in other global methods in Convert.h, please follow existing snake_case convention.
And does CheckCustomOp express the purpose of new method?
Naming is difficult and needs some experience, which may require try and error.
|
@Seunghui98 , this PR has multiple context of changes and title/description of this PR doesn't seem to explain the changes. |
Seunghui98
force-pushed
the
add_custom_op
branch
4 times, most recently
from
f39a238 to
7fd0282
Compare
Seunghui98
changed the title
Seunghui98
force-pushed
the
add_custom_op
branch
from
d5a6d2d to
3fae109
Compare
|
This PR will be reflected after the previous PR. |
This commit includes replacing op type with custom_code if op_type is Custom or extype is Custom. ONE-DCO-1.0-Signed-off-by: SeungHui Lee <[email protected]>
Seunghui98
force-pushed
the
add_custom_op
branch
from
3fae109 to
0e5f38e
Compare
| customcode_set.insert(operation.type()); | ||
| if ((operation.has_extype() && operation.extype() == "Custom") || operation.type() == "Custom") | ||
| { | ||
| assert(operation.custom_code() != ""); |
There was a problem hiding this comment.
This one would be more readable.
| assert(operation.custom_code() != ""); | |
| assert(not operation.custom_code().empty()); |
Seunghui98
force-pushed
the
add_custom_op
branch
2 times, most recently
from
3b99cd9 to
9e7ae17
Compare
Seunghui98
force-pushed
the
add_custom_op
branch
3 times, most recently
from
93864d9 to
3a6ecd8
Compare
|
@seanshpark @mhs4670go |
Seunghui98
force-pushed
the
add_custom_op
branch
from
3a6ecd8 to
c09ace9
Compare
This introduces extype and custom_code for custom operators.
ONE-DCO-1.0-Signed-off-by: SeungHui Lee [email protected]
Related Issue: #11741
Draft PR: #11750