[6.15.z] Fix hostCollection entities #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LadislavVasina1
added
No-CherryPick
This was referenced Sep 18, 2024
vsedmik
approved these changes
Sep 18, 2024
vijaysawant
reviewed
Sep 18, 2024
Comment on lines
+113
to
+114
| submit = self.browser.selenium.find_element(By.XPATH, './/input[@value="Submit"]') | ||
| submit.click() |
There was a problem hiding this comment.
is it possible to move selenium specific code in airgun/views/hostcollection.py?
There was a problem hiding this comment.
I think that I would have to create new subclass just for this one "back ported" change, which is not necessary imo.
vijaysawant
approved these changes
Sep 19, 2024
Comment on lines
+113
to
+114
| submit = self.browser.selenium.find_element(By.XPATH, './/input[@value="Submit"]') | ||
| submit.click() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the fix that is made in SatelliteQE/robottelo#16379
It is 6.15.z specific because in 6.15 when running the install package action via customized REX there is a difference between 6.15 and 6.16 because it uses an old job invocation page that has not been cherry-picked in airgun, so little hacky solution is to hardcode the submit button which can't be found to the entity and submit the prefilled form afterwards. This little fix makes the test work.