Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] Fix hostCollection entities #1564

Merged
merged 1 commit into from
Sep 19, 2024
Merged

[6.15.z] Fix hostCollection entities #1564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion airgun/entities/hostcollection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import time

from navmazing import NavigateToSibling
from selenium.webdriver.common.by import By
from wait_for import wait_for

from airgun.entities.base import BaseEntity
Expand Down Expand Up @@ -105,9 +108,13 @@ def manage_packages(
# After this step the user is redirected to remote execution job
# create view.
job_create_view = HostCollectionActionRemoteExecutionJobCreate(view.browser)
self.browser.plugin.ensure_page_safe(timeout='5s')
job_create_view.fill(job_values)
job_create_view.submit.click()
submit = self.browser.selenium.find_element(By.XPATH, './/input[@value="Submit"]')
submit.click()
Comment on lines +113 to +114
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to move selenium specific code in airgun/views/hostcollection.py?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that I would have to create new subclass just for this one "back ported" change, which is not necessary imo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay


# wait for the job deatils to load
time.sleep(3)
# After this step the user is redirected to job status view.
job_status_view = JobInvocationStatusView(view.browser)
wait_for(
Expand Down