Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codecov #1102

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Remove codecov #1102

merged 1 commit into from
Mar 14, 2024

Conversation

JacobCallahan
Copy link
Member

This continues a trend we've done with other projects. Codecov has some use in other types of projects, but really isn't a good fit for Nailgun since it is functionally exercised by Robottelo.

Without getting too deep into philosophy, CodeCov is a misleading metric for quality and minor changes are largely ignored in mature projects.

@JacobCallahan JacobCallahan added the No-CherryPick PR doesnt need CherryPick to previous branches label Feb 21, 2024
omkarkhatavkar
omkarkhatavkar previously approved these changes Mar 5, 2024
@jyejare
Copy link
Member

jyejare commented Mar 7, 2024

Here are some personal thoughts:

TBH we caught many issues in the past in nailgun using unit tests before merge the PR.

I agree that its an extra overhead but nailgun has simplified form of unit tests where sometimes adding just a line covers the new function.

Also In SatelliteQE testing, we are very dependent on API testing and unit tests here serves as a sanity for automation failures in API functions added in nailgun.

@JacobCallahan
Copy link
Member Author

I'm not saying get rid of the unit tests, I'm saying get rid of codecov as it's a poor measurement of useful tests.

@jyejare
Copy link
Member

jyejare commented Mar 14, 2024

Sure @JacobCallahan , but then could we run tests as part of Pull Request WF to ensure none is failing ?

@JacobCallahan
Copy link
Member Author

@jyejare oohh I didn't even notice that we weren't running tests. Added that to the pull request workflow and they're passing.

This continues a trend we've done with other projects.
Codecov has some use in other types of projects, but really isn't a good
fit for Nailgun since it is functionally exercised by Robottelo.

Without getting too deep into philosophy, CodeCov is a misleading metric
for quality and minor changes are largely ignored in mature projects.
@ogajduse ogajduse merged commit ef2c9e7 into SatelliteQE:master Mar 14, 2024
6 checks passed
@JacobCallahan JacobCallahan deleted the nocov branch March 14, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants