Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing auto release WF from non-master branches #995

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

jyejare
Copy link
Member

@jyejare jyejare commented Sep 14, 2023

Description of changes

Removing the WF for Automatic Releases from non-master branches as only master branch commits are considered in Github Releases!

This was been cherrypicked into 6.14.z during the Branching process which should have been removed !

@jyejare jyejare added No-CherryPick PR doesnt need CherryPick to previous branches 6.14.z labels Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (6.14.z@bc3770c). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             6.14.z     #995   +/-   ##
=========================================
  Coverage          ?   92.15%           
=========================================
  Files             ?        6           
  Lines             ?     3047           
  Branches          ?        0           
=========================================
  Hits              ?     2808           
  Misses            ?      239           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
If we have a documentation for branching, adding an extra step to remove the file from the newly branched .z branch would be a good idea.

@Gauravtalreja1 Gauravtalreja1 merged commit 1709827 into SatelliteQE:6.14.z Oct 20, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.14.z No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants