Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content View Audit Tests #11433

Merged
merged 10 commits into from
Jun 21, 2023
Merged

Content View Audit Tests #11433

merged 10 commits into from
Jun 21, 2023

Conversation

sambible
Copy link
Contributor

@sambible sambible commented May 8, 2023

Leaving this in draft for now, but this will contain a few of the initial tests for the publish audit feature.

Needs this nailgun PR: SatelliteQE/nailgun#922

@sambible sambible added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels May 8, 2023
@sambible sambible requested review from ColeHiggins2, vsedmik, damoore044 and a team May 8, 2023 18:50
@sambible sambible mentioned this pull request May 8, 2023
Merged
@sambible sambible marked this pull request as draft May 8, 2023 20:30
@sambible sambible marked this pull request as draft May 8, 2023 20:30
@lhellebr
Copy link
Contributor

lhellebr commented May 9, 2023

Should this be a draft OR are you requesting review?

@sambible sambible changed the title First test for content-view-audit Content View Audit Tests May 11, 2023
@sambible
Copy link
Contributor Author

Ended up just adding all the tests here, this should be ready for review now as well.

@sambible sambible marked this pull request as ready for review May 11, 2023 22:00
@sambible
Copy link
Contributor Author

This should cover most of the feature, although there will be some additional UI work that I'm going to tackle as part of the Content View Component eval process ( It requires that massive Airgun PR; if you know, you know)

@sambible
Copy link
Contributor Author

Final comment: Can't run PRT on all this stuff yet, as not all of the upstream PRs have made it into stream yet. I'll run it when they all get in.

@sambible sambible force-pushed the content-view-audit branch 2 times, most recently from ae7b534 to 472c0d2 Compare May 16, 2023 14:20
vsedmik
vsedmik requested changes May 17, 2023
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I've just put few questions/comments to address.

tests/foreman/api/test_contentview.py Show resolved Hide resolved
tests/foreman/api/test_contentview.py Show resolved Hide resolved
tests/foreman/api/test_contentview.py Show resolved Hide resolved
tests/foreman/api/test_contentview.py Outdated Show resolved Hide resolved
tests/foreman/api/test_contentview.py Outdated Show resolved Hide resolved
tests/foreman/api/test_contentview.py Show resolved Hide resolved
Griffin-Sullivan
Griffin-Sullivan reviewed May 25, 2023
View reviewed changes
tests/foreman/api/test_contentview.py Outdated Show resolved Hide resolved
tests/foreman/api/test_contentview.py Outdated Show resolved Hide resolved
tests/foreman/api/test_contentview.py Outdated Show resolved Hide resolved
tests/foreman/api/test_contentview.py Show resolved Hide resolved
@Griffin-Sullivan
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_ccv_audit_scenarios tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_check_needs_publish_flag tests/foreman/api/test_contentview.py::TestContentViewRedHatContent::test_cv_audit_scenarios
nailgun: 922

@sambible sambible added CherryPick PR needs CherryPick to previous branches 6.14.z Introduced in or relating directly to Satellite 6.14 and removed No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jun 1, 2023
@JacobCallahan
Copy link
Member

trigger: test-robottelo
pytest: tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_ccv_audit_scenarios tests/foreman/api/test_contentview.py::TestContentViewPublishPromote::test_check_needs_publish_flag tests/foreman/api/test_contentview.py::TestContentViewRedHatContent::test_cv_audit_scenarios
nailgun: 922

ColeHiggins2
ColeHiggins2 reviewed Jun 7, 2023
View reviewed changes
Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not too familiar with content view audit tests. but would these be considered end to end? @sambible if so maybe we could add a tag to these

vsedmik
vsedmik approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need the nailgun PR merged too

@Gauravtalreja1 Gauravtalreja1 added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jun 21, 2023
@Gauravtalreja1 Gauravtalreja1 merged commit e7b264d into SatelliteQE:master Jun 21, 2023
@Satellite-QE Satellite-QE mentioned this pull request Jun 21, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Jun 21, 2023
@sambible @web-flow
Content View Audit Tests (#11433)
2a58db9 
* First test for content-view-audit

* First test for content-view-audit

* add more test cases and a test for composite content views

* Add test for publish_only_if_needed flag

* Remove unnecessary file.

* Finish test for composite content views

* address review comments

* Remove stream markers, change entity to target_sat

(cherry picked from commit e7b264d)
damoore044 pushed a commit to damoore044/robottelo that referenced this pull request Jun 22, 2023
@sambible @damoore044
Content View Audit Tests (SatelliteQE#11433)
1253430 
* First test for content-view-audit

* First test for content-view-audit

* add more test cases and a test for composite content views

* Add test for publish_only_if_needed flag

* Remove unnecessary file.

* Finish test for composite content views

* address review comments

* Remove stream markers, change entity to target_sat
vsedmik pushed a commit that referenced this pull request Jun 28, 2023
@Satellite-QE @sambible
[6.14.z] Content View Audit Tests (#11718)
1b25640 
Content View Audit Tests (#11433)

* First test for content-view-audit

* First test for content-view-audit

* add more test cases and a test for composite content views

* Add test for publish_only_if_needed flag

* Remove unnecessary file.

* Finish test for composite content views

* address review comments

* Remove stream markers, change entity to target_sat

(cherry picked from commit e7b264d)

Co-authored-by: Samuel Bible <[email protected]>
ColeHiggins2 pushed a commit to ColeHiggins2/robottelo that referenced this pull request Oct 9, 2023
@sambible @ColeHiggins2
Content View Audit Tests (SatelliteQE#11433)
5590893 
* First test for content-view-audit

* First test for content-view-audit

* add more test cases and a test for composite content views

* Add test for publish_only_if_needed flag

* Remove unnecessary file.

* Finish test for composite content views

* address review comments

* Remove stream markers, change entity to target_sat
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@sambible @shweta83
Content View Audit Tests (SatelliteQE#11433)
f590060 
* First test for content-view-audit

* First test for content-view-audit

* add more test cases and a test for composite content views

* Add test for publish_only_if_needed flag

* Remove unnecessary file.

* Finish test for composite content views

* address review comments

* Remove stream markers, change entity to target_sat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

@ColeHiggins2 ColeHiggins2 ColeHiggins2 left review comments

@damoore044 damoore044 damoore044 approved these changes

@vsedmik vsedmik vsedmik approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@JacobCallahan JacobCallahan JacobCallahan approved these changes

Assignees

@sambible sambible

Labels
6.14.z Introduced in or relating directly to Satellite 6.14 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sambible @lhellebr @Griffin-Sullivan @JacobCallahan @Gauravtalreja1 @ColeHiggins2 @vsedmik @damoore044