[6.16.z] Avoid calling decode on str #16304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid calling decode on str
In tests we see this failure:
AttributeError: 'str' object has no attribute 'decode'. Did you mean: 'encode'?
This implies that the strerr value is a str, which you can't decode. I
can't find the specific change, but this implies the result used to be a
byte string and is now decoded elsewhere.
* Update tests/foreman/destructive/test_rename.py
Co-authored-by: Peter Ondrejka <[email protected]>
* Update tests/foreman/destructive/test_rename.py
Co-authored-by: Evgeni Golov <[email protected]>
---------
Co-authored-by: Peter Ondrejka <[email protected]>
Co-authored-by: Jameer Pathan <[email protected]>
Co-authored-by: Evgeni Golov <[email protected]>
(cherry picked from commit 5c05d4f)
Satellite-QE
added
6.16.z
Auto_Cherry_Picked
|
trigger: test-robottelo |
Satellite-QE
added
the
AutoMerge_Cherry_Picked
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
Satellite-QE
deleted the
cherry-pick-6.16.z-5c05d4fd72c0ad5472c0d8cc1a3702cce27f6f9b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #16214
Problem Statement
In tests we see this failure:
Solution
This implies that the strerr value is a str, which you can't decode. I can't find the specific change, but this implies the result used to be a byte string and is now decoded elsewhere.
Related Issues