Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.16.z] Avoid calling decode on str #16304

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[6.16.z] Avoid calling decode on str #16304

merged 1 commit into from
Sep 10, 2024

Commits on Sep 10, 2024

  1. Avoid calling decode on str (#16214) 

    * Avoid calling decode on str

In tests we see this failure:

    AttributeError: 'str' object has no attribute 'decode'. Did you mean: 'encode'?

This implies that the strerr value is a str, which you can't decode. I
can't find the specific change, but this implies the result used to be a
byte string and is now decoded elsewhere.

* Update tests/foreman/destructive/test_rename.py

Co-authored-by: Peter Ondrejka <[email protected]>

* Update tests/foreman/destructive/test_rename.py

Co-authored-by: Evgeni Golov <[email protected]>

---------

Co-authored-by: Peter Ondrejka <[email protected]>
Co-authored-by: Jameer Pathan <[email protected]>
Co-authored-by: Evgeni Golov <[email protected]>
(cherry picked from commit 5c05d4f)
    @ekohl @web-flow
    ekohl authored and web-flow committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    befe2de View commit details
    Browse the repository at this point in the history