Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from module to function fixtures #16345

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Change from module to function fixtures #16345

merged 1 commit into from
Sep 12, 2024

Conversation

sambible
Copy link
Contributor

Problem Statement

I was seeing issues sharing module level fixtures with other tests in the class

Solution

Change the module fixture to function level fixtures, to better work in CI.

Related Issues

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_manage_errata'

@sambible sambible added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.16.z Introduced in or relating directly to Satellite 6.16 labels Sep 12, 2024
@sambible sambible requested a review from a team September 12, 2024 15:58
@sambible sambible self-assigned this Sep 12, 2024
@sambible sambible requested a review from a team as a code owner September 12, 2024 15:58
vsedmik
vsedmik approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewisely looks good to me, PRT pending.

@vsedmik
Copy link
Contributor

vsedmik commented Sep 12, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_manage_errata'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8628
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_host.py -k test_all_hosts_manage_errata --external-logging
Test Result : ========= 4 passed, 73 deselected, 644 warnings in 2546.94s (0:42:26) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 12, 2024
@sambible sambible requested a review from a team September 12, 2024 17:41
@ColeHiggins2 ColeHiggins2 merged commit 8b0e3e0 into SatelliteQE:master Sep 12, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 12, 2024
@sambible @web-flow
Change from module to function fixtures (#16345)
4ba2fdc 
(cherry picked from commit 8b0e3e0)
@Satellite-QE Satellite-QE mentioned this pull request Sep 12, 2024
Merged
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@sambible @jyejare
Change from module to function fixtures (SatelliteQE#16345)
8e36fe1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

Assignees

@sambible sambible

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sambible @vsedmik @Satellite-QE @ColeHiggins2