Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing cloned_from_id key from template object #16813

Merged
merged 1 commit into from
Nov 4, 2024
Merged

removing cloned_from_id key from template object #16813

merged 1 commit into from
Nov 4, 2024

Conversation

amolpati30
Copy link
Contributor

Problem Statement

The value of cloned_from_id differs between the two instances, while the rest of the data matches. Since dupe_json is cloned from template, it inherits the id from template, whereas the template object itself was created directly and does not have a clone id . And it causes an assertion error. I remove cloned_from_id to prevent the assertion from failing.

Solution

I remove cloned_from_id key to prevent the assertion from failing and removing cloned_from_id does not impact the test.

@amolpati30 amolpati30 added Easy Fix :) Easiest Fix to review and quick merge request. CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.16.z Introduced in or relating directly to Satellite 6.16 labels Oct 29, 2024
@amolpati30 amolpati30 requested a review from a team as a code owner October 29, 2024 13:15
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_provisioningtemplate.py::TestProvisioningTemplate::test_positive_end_to_end_crud

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9177
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_provisioningtemplate.py::TestProvisioningTemplate::test_positive_end_to_end_crud --external-logging
Test Result : ================== 1 passed, 9 warnings in 570.90s (0:09:30) ===================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 29, 2024
shubhamsg199
shubhamsg199 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@amolpati30 amolpati30 added 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 labels Nov 4, 2024
@shubhamsg199 shubhamsg199 merged commit de22c82 into SatelliteQE:master Nov 4, 2024
16 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 4, 2024
@amolpati30 @web-flow
removing cloned_from_id key from template object (#16813)
777e887 
removing cloned_from_id key from template

(cherry picked from commit de22c82)
github-actions bot pushed a commit that referenced this pull request Nov 4, 2024
@amolpati30 @web-flow
removing cloned_from_id key from template object (#16813)
16a87b4 
removing cloned_from_id key from template

(cherry picked from commit de22c82)
This was referenced Nov 4, 2024
Merged
Merged
github-actions bot pushed a commit that referenced this pull request Nov 4, 2024
@amolpati30 @web-flow
removing cloned_from_id key from template object (#16813)
2128329 
removing cloned_from_id key from template

(cherry picked from commit de22c82)
@Satellite-QE Satellite-QE mentioned this pull request Nov 4, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Nov 4, 2024
@amolpati30 @web-flow
removing cloned_from_id key from template object (#16813)
c9d6ad2 
removing cloned_from_id key from template

(cherry picked from commit de22c82)
@Satellite-QE Satellite-QE mentioned this pull request Nov 4, 2024
Merged
amolpati30 added a commit that referenced this pull request Nov 5, 2024
@Satellite-QE @amolpati30
[6.14.z] removing cloned_from_id key from template object (#16845)
e59769a 
removing cloned_from_id key from template object (#16813)

removing cloned_from_id key from template

(cherry picked from commit de22c82)

Co-authored-by: amolpati30 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@amolpati30 amolpati30

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches Easy Fix :) Easiest Fix to review and quick merge request. PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amolpati30 @Satellite-QE @pondrejk @shubhamsg199