Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache and initialization tests #304

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

jClugstor
Copy link
Contributor

@jClugstor jClugstor commented Jan 2, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Oops, I could have sworn I made this PR last week
The cache tests that are @test_nowarn were failing because of the new ADTypes integration for OrdinaryDiffEq. Setting the chunk_size to 1 should be unecessary, since that will happen automatically anyway.

@jClugstor jClugstor changed the title Fix cache tests Fix cache and initialization tests Jan 2, 2025
@jClugstor
Copy link
Contributor Author

This is strange... interface tests are failing for only the x86 tests. I can't really reproduce locally since I don't have an x86 machine, hmm

@devmotion
Copy link
Member

I can't really reproduce locally since I don't have an x86 machine, hmm

IIRC you don't need a special machine, you just have to run 32bit julia (on eg a 64bit machine).

@jClugstor
Copy link
Contributor Author

Oh cool thanks, I'll check that out then.

@ChrisRackauckas
Copy link
Member

I think that's something in OrdinaryDiffEq. Should look into, but it doesn't block this.

@ChrisRackauckas ChrisRackauckas merged commit 97dd24c into SciML:master Jan 3, 2025
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants