Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache and initialization tests #304

Merged
merged 6 commits into from
Jan 3, 2025
Merged

Fix cache and initialization tests #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
20e7058
with chunk_size kwarg, these will warn now. Setting chunk_size to 1 s…
jClugstor Jan 2, 2025
3631275
fix rosenbrock chunksize
jClugstor Jan 2, 2025
a7eed8e
import SciMLBase for initialization test
jClugstor Jan 2, 2025
4e6869b
redundant using
jClugstor Jan 2, 2025
1690f89
fix initialization test
jClugstor Jan 2, 2025
5509f62
using not needed?
jClugstor Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/integrators/cache.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@ end
println("Check some other integrators")

println("Rosenbrock23")
@test_nowarn solve(prob, MethodOfSteps(Rosenbrock23(chunk_size = 1)); dt = 0.5)
@test_nowarn solve(prob, MethodOfSteps(Rosenbrock23()); dt = 0.5)

@testset "$(nameof(typeof(alg)))" for alg in CACHE_TEST_ALGS
@test_nowarn solve(prob, MethodOfSteps(alg); dt = 0.5)
end

println("Rodas4")
@test_nowarn solve(prob, MethodOfSteps(Rodas4(chunk_size = 1)); dt = 0.5)
@test_nowarn solve(prob, MethodOfSteps(Rodas4()); dt = 0.5)

println("Rodas5")
@test_nowarn solve(prob, MethodOfSteps(Rodas5(chunk_size = 1)); dt = 0.5)
@test_nowarn solve(prob, MethodOfSteps(Rodas5()); dt = 0.5)
5 changes: 2 additions & 3 deletions test/integrators/initialization.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using DelayDiffEq
using SciMLBase
using LinearAlgebra
using Test

Expand All @@ -26,13 +25,13 @@ using Test
prob_ddae = DDEProblem(
DDEFunction{true}(sir_ddae!;
mass_matrix = Diagonal([1.0, 1.0, 0.0])),
u0,
u0_good,
sir_history,
tspan,
p;
constant_lags = (p.τ,))
alg = MethodOfSteps(Rosenbrock23())
@test_nowarn init(prob_ddae, alg)
prob.u0[1] = 2.0
prob_ddae.u0[1] = 2.0
@test_throws SciMLBase.CheckInitFailureError init(prob_ddae, alg)
end
Loading