fix(shim): properly check wslpath/cygpath command first
#6114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
niheaven
reviewed
Aug 19, 2024
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Note: - Passing arguments to mingw/cygwin bash does not work without `bash -c` - Not much I can do for PowerShell: https://github.com/Azure/azure-cli/blob/dev/doc/quoting-issues-with-powershell.md
niheaven
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not suppress stderr for commands, only suppress output when checking for
wslpath/cygpathcommands first.Motivation and Context
Closes #6112
How Has This Been Tested?
wcurlat ScoopInstaller/Main#6117Before: Error, no output
After: now returns an error with the output
Checklist:
developbranch.