add 2fa flows (wip) #604
Draft
add 2fa flows (wip) #604
+4,077
−855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen freshly loading a new route
🚀 Preview Deployments
|
TroyKomodo
reviewed
Sep 29, 2025
scuffle-brawl bot
added a commit
that referenced
this pull request
Oct 5, 2025
feat(core): dashboard origin from request This PR adds the ability for the core service to take the dashboard origin from the request `Origin` header instead of a static config value. This has the advantage that the server can be used with any frontend independent of its URL. This fixes the login in the preview deployments. (like #604) Requested-by: lennartkloock <[email protected]> Reviewed-by: SimaoMoreira5228 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes to existing login flow. Added 2fa management to settings page. Upgraded base svelte version to be compatible with tanstack
https://github.com/TanStack/query/releases/tag/%40tanstack%2Fsvelte-query%406.0.0
https://tanstack.com/query/latest/docs/framework/svelte/migrate-from-v5-to-v6
Tanstack (query management for SPAs - well I think they're only good for SPAs at least) made a large update 5 days ago to have more svelte 5 runes support and they appear committed to supporting svelte. I think they're a good choice for this project and have examples in this PR.
Open to comments mainly on the $effect logic in the layout page or something similar it and it's long term viability but I can't think of any alternatives currently. Since we're using client-side authentication I can't take advantage of any server side routing. So I end up having to manage redirects all in the f/e so it makes sense to put it all in one place is my line of thinking.
It might actually be correct? Just need to wrap f/e api calls where we check the status code of the response and appropriately redirect if it's unauthorized. Here's an interesting related thread