test: assert compatibility with DbReader (#1054)

* test: add new test to cover DbReader MicroORM
* fix: set Sqlite as not supported for DbReader

DubUrl.Core/Querying/Dialects/Casters/DateTimeCaster.cs

@@ -23,7 +23,7 @@ public DateTimeCaster()
     protected bool TryTruncate(DateTime value, out T? result)
     {
         var parse = GetMethod();
-        result = (T?)(parse?.Invoke(null, new object[] { value }));
+        result = (T?)(parse?.Invoke(null, [value]));
         return parse is not null;
     }
 }

DubUrl.Core/Querying/Dialects/Casters/TimeSpanCaster.cs

@@ -23,7 +23,7 @@ public TimeSpanCaster()
     protected bool TryTruncate(TimeSpan value, out T? result)
     {
         var parse = GetMethod();
-        result = (T?)(parse?.Invoke(null, new object[] { value }));
+        result = (T?)(parse?.Invoke(null, [value]));
         return parse is not null;
     }
 }

DubUrl.Core/Registering/BinFolderDiscoverer.cs

@@ -37,15 +37,15 @@ public virtual IEnumerable<Type> Execute()
     {
         var files = Assemblies.Aggregate(
                 Array.Empty<string>(), (seed, asm) =>
-                seed.Concat(new[] { asm?.Location ?? string.Empty }).ToArray()
+                [.. seed, .. new[] { asm?.Location ?? string.Empty }]
             )
             .Where(x => !string.IsNullOrEmpty(x))
             .Distinct()
             .Select(Path.GetDirectoryName)
             .Where(Directory.Exists)
             .Aggregate(
                 Array.Empty<string>(), (seed, location) =>
-                seed.Concat(Directory.GetFiles(location!)).ToArray()
+                [.. seed, .. Directory.GetFiles(location!)]
             )
             .Where(x => Path.GetExtension(x) == ".dll");
 

DubUrl.QA/BaseAdoProvider.cs

@@ -4,10 +4,10 @@
 using DubUrl.Extensions.DependencyInjection;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Configuration;
-using Dapper;
-using DubUrl.QA.Dapper;
 using static DubUrl.QA.MicroOrmCustomerRepository;
 using System.Linq.Expressions;
+using Dapper;
+using DbReader;
 
 namespace DubUrl.QA;
 
@@ -308,12 +308,12 @@ public virtual void QueryCustomerWithDapperRepository()
         using var provider = new ServiceCollection()
             .AddSingleton(EmptyDubUrlConfiguration)
             .AddDubUrl(options)
-            .AddSingleton<IDapperConfiguration>(
-                provider => ActivatorUtilities.CreateInstance<DapperConfiguration>(provider
+            .AddSingleton<Dapper.IDapperConfiguration>(
+                provider => ActivatorUtilities.CreateInstance<Dapper.DapperConfiguration>(provider
                     , new[] { ConnectionString }))
-            .AddTransient<ICustomerRepository, DapperCustomerRepository>()
+            .AddTransient<Dapper.ICustomerRepository, Dapper.DapperCustomerRepository>()
             .BuildServiceProvider();
-        var repo = provider.GetRequiredService<ICustomerRepository>();
+        var repo = provider.GetRequiredService<Dapper.ICustomerRepository>();
         var customers = repo.GetAllAsync().Result;
         Assert.That(customers, Has.Count.EqualTo(5));
         Assert.Multiple(() =>
@@ -324,4 +324,23 @@ public virtual void QueryCustomerWithDapperRepository()
             Assert.That(customers.Any(x => x.BirthDate == DateTime.MinValue), Is.False);
         });
     }
+
+    [Test]
+    [Category("DbReader")]
+    public abstract void QueryCustomerWithDbReader();
+    protected void QueryCustomerWithDbReader(string sql)
+    {
+        var connectionUrl = new ConnectionUrl(ConnectionString);
+
+        using var conn = connectionUrl.Open();
+        var customers = conn.Read<DbReader.Customer>(sql).ToList();
+        Assert.That(customers, Has.Count.EqualTo(5));
+        Assert.Multiple(() =>
+        {
+            Assert.That(customers.Select(x => x.CustomerId).Distinct().ToList(), Has.Count.EqualTo(5));
+            Assert.That(customers.Any(x => string.IsNullOrEmpty(x.FullName)), Is.False);
+            Assert.That(customers.Select(x => x.BirthDate).Distinct().ToList(), Has.Count.EqualTo(5));
+            Assert.That(customers.Any(x => x.BirthDate == DateTime.MinValue), Is.False);
+        });
+    }
 }

DubUrl.QA/BaseAdomdProvider.cs

@@ -369,4 +369,23 @@ public virtual void QueryCustomerWithDapperRepository()
             Assert.That(customers.Any(x => x.BirthDate == DateTime.MinValue), Is.False);
         });
     }
+
+    [Test]
+    [Category("DbReader")]
+    public abstract void QueryCustomerWithDbReader();
+    protected void QueryCustomerWithDbReader(string sql)
+    {
+        var connectionUrl = new ConnectionUrl(ConnectionString);
+
+        using var conn = connectionUrl.Open();
+        var customers = conn.Query<DbReader.Customer>(sql).ToList();
+        Assert.That(customers, Has.Count.EqualTo(5));
+        Assert.Multiple(() =>
+        {
+            Assert.That(customers.Select(x => x.CustomerId).Distinct().ToList(), Has.Count.EqualTo(5));
+            Assert.That(customers.Any(x => string.IsNullOrEmpty(x.FullName)), Is.False);
+            Assert.That(customers.Select(x => x.BirthDate).Distinct().ToList(), Has.Count.EqualTo(5));
+            Assert.That(customers.Any(x => x.BirthDate == DateTime.MinValue), Is.False);
+        });
+    }
 }

DubUrl.QA/CockRoach/AdoProviderCockRoach.cs

@@ -38,7 +38,11 @@ public override void QueryCustomerWithPositionalParameter()
     public override void QueryCustomerWithDapper()
         => QueryCustomerWithDapper("select * from Customer");
 
+    [Test]
+    public override void QueryCustomerWithDbReader()
+        => QueryCustomerWithDbReader("select * from Customer");
+
     [Test]
     public override void QueryCustomerWithWhereClause()
         => Assert.Ignore("Issue with lower in template");
-}
+}

DubUrl.QA/DbReader/Customer.cs

@@ -0,0 +1,14 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace DubUrl.QA.DbReader;
+
+internal record Customer(
+    int CustomerId,
+    string FullName,
+    DateTime BirthDate
+)
+{ }

DubUrl.QA/DubUrl.QA.csproj

@@ -88,6 +88,7 @@
   </ItemGroup>
 
   <ItemGroup>
+    <PackageReference Include="DbReader" Version="2.6.0" />
     <PackageReference Include="DuckDB.NET.Bindings.Full" Version="1.0.1" />
     <PackageReference Include="Dapper" Version="2.1.44" />
     <PackageReference Include="DuckDB.NET.Data" Version="1.0.1" />

DubUrl.QA/DuckDB/AdoProviderDuckDB.cs

@@ -32,6 +32,10 @@ public override void QueryCustomerWithPositionalParameter()
     public override void QueryCustomerWithDapper()
         => QueryCustomerWithDapper("select * from Customer");
 
+    [Test]
+    public override void QueryCustomerWithDbReader()
+        => QueryCustomerWithDbReader("select * from Customer");
+
     [Test]
     public override void QueryCustomerWithWhereClause()
         => Assert.Ignore("Object of type 'DuckDB.NET.DuckDBDateOnly' cannot be converted to type 'System.DateTime'");

DubUrl.QA/FirebirdSQL/AdoProviderFirebirdSQL.cs

@@ -40,4 +40,8 @@ public override void QueryCustomerWithPositionalParameter()
     [Test]
     public override void QueryCustomerWithDapper()
         => QueryCustomerWithDapper("select * from Customer");
+
+[Test]
+    public override void QueryCustomerWithDbReader()
+        => QueryCustomerWithDapper("select CustomerId as \"CustomerId\", FullName as \"FullName\", BirthDate as \"BirthDate\" from Customer");
 }

DubUrl.QA/MsSqlServer/AdoProviderMsSqlServer.cs

@@ -37,4 +37,8 @@ public override void QueryCustomerWithPositionalParameter()
     public override void QueryCustomerWithDapper()
         => QueryCustomerWithDapper("select * from Customer");
 
-}
+    [Test]
+    public override void QueryCustomerWithDbReader()
+        => QueryCustomerWithDbReader("select * from Customer");
+
+}

DubUrl.QA/Mysql/AdoProviderMySQL.cs

@@ -37,4 +37,7 @@ public override void QueryCustomerWithPositionalParameter()
     [Test]
     public override void QueryCustomerWithDapper()
         => QueryCustomerWithDapper("select * from Customer");
+    [Test]
+    public override void QueryCustomerWithDbReader()
+        => QueryCustomerWithDbReader("select * from Customer");
 }

DubUrl.QA/Postgresql/BaseAdoProviderPostgresql.cs

@@ -24,4 +24,8 @@ public override void QueryCustomerWithPositionalParameter()
     [Test]
     public override void QueryCustomerWithDapper()
         => QueryCustomerWithDapper("select * from \"Customer\"");
+
+    [Test]
+    public override void QueryCustomerWithDbReader()
+        => QueryCustomerWithDapper("select * from \"Customer\"");
 }

DubUrl.QA/PowerBiDesktop/AdomdProviderPowerBiDesktop.cs

@@ -36,11 +36,14 @@ public override void QueryCustomerWithPositionalParameter()
     public override void QueryCustomerWithDapper()
         => QueryCustomerWithDapper("EVALUATE SELECTCOLUMNS(Customer, \"CustomerId\" , Customer[CustomerId], \"FullName\" , Customer[FullName], \"BirthDate\" , Customer[BirthDate])");
 
+    [Test]
+    public override void QueryCustomerWithDbReader()
+        => QueryCustomerWithDapper("EVALUATE SELECTCOLUMNS(Customer, \"CustomerId\" , Customer[CustomerId], \"FullName\" , Customer[FullName], \"BirthDate\" , Customer[BirthDate])");
     //[Test]
     //public override void QueryTwoYoungestCustomersWithRepositoryFactory()
     //    => Assert.Ignore("Not investigated why, but not working");
 
     //[Test]
     //public override void QueryCustomerWithWhereClause()
     //    => Assert.Ignore("Not investigated why, but not working");
-}
+}

DubUrl.QA/SingleStore/AdoProviderSingleStore.cs

@@ -35,4 +35,8 @@ public override void QueryCustomerWithPositionalParameter()
     [Test]
     public override void QueryCustomerWithDapper()
         => QueryCustomerWithDapper("select * from Customer");
+
+    [Test]
+    public override void QueryCustomerWithDbReader()
+        => QueryCustomerWithDbReader("select * from Customer");
 }

DubUrl.QA/Sqlite/AdoProviderSqlite.cs

@@ -35,4 +35,8 @@ public override void QueryCustomerWithPositionalParameter()
     [Test]
     public override void QueryCustomerWithDapper()
         => QueryCustomerWithDapper("select * from Customer");
-}
+
+    [Test]
+    public override void QueryCustomerWithDbReader()
+        => Assert.Ignore("Not investigated");
+}

DubUrl.QA/SsasMultidim/AdomdProviderSsasMultidim.cs

@@ -33,6 +33,10 @@ public override void QueryCustomerWithPositionalParameter()
     public override void QueryCustomerWithDapper()
         => Assert.Ignore("Test not implemented");
 
+    [Test]
+    public override void QueryCustomerWithDbReader()
+        => Assert.Ignore("Test not implemented");
+
     [Test]
     [Category("DatabaseUrl")]
     [Category("Primitive")]

DubUrl.QA/SsasTabular/AdomdProviderSsasTabular.cs

@@ -33,6 +33,10 @@ public override void QueryCustomerWithPositionalParameter()
     public override void QueryCustomerWithDapper()
         => Assert.Ignore("Test not implemented");
 
+    [Test]
+    public override void QueryCustomerWithDbReader()
+        => Assert.Ignore("Test not implemented");
+
     [Test]
     public override void QueryCustomerWithRepository()
         => Assert.Ignore("Test not implemented");

DubUrl.QA/Trino/AdoProviderTrino.cs

@@ -31,7 +31,11 @@ public override void QueryCustomerWithPositionalParameter()
     [Test]
     public override void QueryCustomerWithDapper()
         => Assert.Ignore("Unable to cast object of type 'System.Int64' to type 'System.Int32'");
-
+
+    [Test]
+    public override void QueryCustomerWithDbReader()
+        => Assert.Ignore("Unable to cast object of type 'System.Int64' to type 'System.Int32'");
+
     [Test]
     public override void QueryCustomerWithDapperRepository()
                 => Assert.Ignore("Unable to cast object of type 'System.Int64' to type 'System.Int32'");
@@ -44,4 +48,4 @@ public override void QueryTwoYoungestCustomersWithRepositoryFactory()
     //[Test]
     //public override void QueryIntervalWithDatabaseUrl()
     //    => Assert.Ignore("Trino doesn't support 'Interval' type");
-}
+}