Skip to content

Commit

Permalink
Added in default setting validation
Browse files Browse the repository at this point in the history
  • Loading branch information
AribaRajput committed Dec 19, 2024
1 parent 6f90bcc commit 8f6b402
Show file tree
Hide file tree
Showing 8 changed files with 790 additions and 214 deletions.
2 changes: 1 addition & 1 deletion .changeset/chilled-bugs-juggle.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
'theme-check-vscode': minor
---

Add the `ValidPresetSettings` check. This check will allow us to validate that the settings defined in sections and blocks are valid. They are valid if they exist in either the block settings or the section settings.
Add the `ValidPresetAndDefaultSettings` check. This check will allow us to validate that the settings defined in sections and blocks are valid. They are valid if they exist in either the block settings or the section settings.
4 changes: 2 additions & 2 deletions packages/theme-check-common/src/checks/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import { ValidSchemaName } from './valid-schema-name';
import { ValidStaticBlockType } from './valid-static-block-type';
import { VariableName } from './variable-name';
import { MissingSchema } from './missing-schema';
import { ValidPresetSettings } from './valid-preset-settings';
import { ValidPresetAndDefaultSettings } from './valid-preset-and-default-settings';

export const allChecks: (LiquidCheckDefinition | JSONCheckDefinition)[] = [
AppBlockValidTags,
Expand Down Expand Up @@ -93,7 +93,7 @@ export const allChecks: (LiquidCheckDefinition | JSONCheckDefinition)[] = [
ValidStaticBlockType,
VariableName,
ValidSchemaName,
ValidPresetSettings,
ValidPresetAndDefaultSettings,
];

/**
Expand Down
Loading

0 comments on commit 8f6b402

Please sign in to comment.