Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: allow biomass reclaimer to reclaim plants #150

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #23731: allow biomass reclaimer to reclaim plants from space-wizards space-wizards/space-station-14

ec4e0990e16f70e6e4a2c1461680240f78cccaf3

PR opened by Ilya246 at 2024-01-08 09:45:55 UTC
PR merged by web-flow at 2024-03-11 21:59:21 UTC


PR changed 2 files with 45 additions and 11 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

About the PR

title: allows biomass reclaimer to reclaim plants at 0.5 biomass per plant
also makes insertion doafter time scale with mass of inserted entity
also fixes click insertion (as opposed to drag insertion) not working

Why / Balance

provides a fallback way to obtain biomass if cargo is not doing their job
since cloning is not real, makes it actually feasible to obtain biomass for the biofabricator
if cloning were real, seems like it would still be balanced with the amounts it gives

Technical details

also cleans up BiomassReclaimerComponent's DataField tags

Media

tested, works
trust

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • tweak: The biomass reclaimer may now reclaim plants, and inserting smaller entities into it is now faster.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 5, 2024 00:02
@VMSolidus VMSolidus enabled auto-merge (squash) May 6, 2024 18:45
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add it to the TODO list to make special MEATY plants that are really good for biomassing.

@VMSolidus VMSolidus merged commit 2f7c608 into Simple-Station:master May 6, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants