Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Space damage now causes heat along with blunt #154

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25770: Space damage now causes heat along with blunt from space-wizards space-wizards/space-station-14

c2d52e45404f09b95f87dbb8e12d2a0c7217a023

PR opened by UbaserB at 2024-03-02 07:11:43 UTC
PR merged by web-flow at 2024-03-12 02:38:40 UTC


PR changed 2 files with 4 additions and 2 deletions.

The PR had the following labels:

  • Needs Discussion
  • No C#
  • Status: Needs Review

Original Body

About the PR

Space burns your skin from the ionizing radiation and intense light. Also, your blood boils. Radiation would be too difficult to implement and generally not a good idea, so i decided to just do burn. The reason why it's under barotrauma instead of general space damage is because even if you're not in space your blood still boils from lack of pressure (aka barotrauma)

Makes space a tiny teensy little bit more dangerous by 0.5 damage increase per second along with making treatment more complex considering there is another added damage type.

image

Changelog

🆑 Ubaser

  • tweak: Unpressurized areas now deal heat damage along with blunt.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 21, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is heat the same as cold damage? if it is, okay. if it's not, should be changed

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@stellar-novas
Copy link
Contributor

Applying any form of heat damage is odd. The only damage players should really take is asphyx and blunt due to barotrauma.

Vacuum insulated thermoses exist for a reason, radiative heat transfer is very slow.

The only additional damage types that could exist are heat and radiation, and those should be based on line of sight to the star. For context, space-wizards/space-station-14#25770 and space-wizards/space-station-14#26478.

I'm saying we close this, remove cold damage, and add solar damage soon ™️

@DangerRevolution DangerRevolution marked this pull request as ready for review May 11, 2024 21:02
@DangerRevolution DangerRevolution self-assigned this May 11, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label May 11, 2024
@DangerRevolution DangerRevolution added Changes: YML Changes any yml files Priority: 2-High Needs to be resolved as soon as possible Size: 4-Small For small issues/PRs Status: Needs Discussion Must be discussed Type: Feature Creation of or significant changes to a feature labels May 11, 2024
@DangerRevolution
Copy link
Contributor

just gonna mark this with discussion, 🤷

VMSolidus
VMSolidus previously approved these changes May 29, 2024
@VMSolidus
Copy link
Member

I'll agree with Nova that this isn't a needed change, and also, that's not even how space works either. Space isn't hot for any conventional reason, at least not in any reason that could be abstracted away as "Heat damage".

@VMSolidus VMSolidus closed this May 29, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Priority: 2-High Needs to be resolved as soon as possible Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Size: 4-Small For small issues/PRs Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this Type: Feature Creation of or significant changes to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants